Update lect-w07-enums.tex #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Console.BLUE to Console.BLACK to match enum case Black.
|
Well, is you have a black or dark background the blue is a better color to show a black playing card... So this was actually deliberate. Or do you think it is too confusing? |
|
A student was confused by the difference, maybe you can add a comment to explain the thought process. |
|
If there is room on the slide you can perhaps update your PR to keep BLUE but add a comment that "Blå färg syns på svart bakgrund" or similar -- IF there is room on the slide (?)... |
Add a comment to explain the reason behind using Console.BLUE.
|
Updated my PR, but merge this minor clarification if you see it is necessary( and correct). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Console.BLUE to Console.BLACK to match enum case Black.