Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punkt tillagd mellan "xs" och "map" i Uppgift 5, W02 #747

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

Aresiel
Copy link
Contributor

@Aresiel Aresiel commented Sep 5, 2023

Det saknas en punkt mellan xs och main här: (Uppgift 5, W02)
image
Med tanke på svarsalternativ antar jag punkten bör vara där.

@bjornregnell
Copy link
Member

bjornregnell commented Sep 5, 2023

Have you tried it? It actually works due to infix operator notation, which I briefly mentioned during this week's lecture. So I'm inclined to keep it. Or do you think it is better to wait until w03 to show infix notation? In that case also the space before the left parenthesis should go away to be idiomatic...

@Aresiel
Copy link
Contributor Author

Aresiel commented Sep 5, 2023

Have you tried it? It actually works due to infix operator notation, which I briefly mentioned during this week's lecture. So I'm inclined to keep it. Or do you think it is better to wait until w03 to show infix notation? In that case also the space before the left parenthesis should go away to be idiomatic...

You're right, I didn't think about that. It might be confusing to introduce it this early, especially since it looks like a typo, but there are also benefits of introducing it early. On the other hand it's also explicitly not recommended at the bottom of this page on the Scala style guide, so it might be best to avoid due to that.

I'll make a commit removing the space after and you can decide whether to merge.

@bjornregnell bjornregnell merged commit 971c05d into lunduniversity:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants