Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing vector methods #228

Merged
merged 15 commits into from
Jul 21, 2024
Merged

Add missing vector methods #228

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fb888ce
Add Vector2:Angle(rhs)
ZachCurtis Jul 16, 2024
b0f1a87
Add Vector2:FuzzyEq(rhs)
ZachCurtis Jul 16, 2024
bdffd37
Add Vector2:Abs()
ZachCurtis Jul 16, 2024
1f35f02
Add Vector2:Ceil()
ZachCurtis Jul 16, 2024
3170b2a
Add Vector2:Floor()
ZachCurtis Jul 16, 2024
431b4ea
Add Vector2:Sign()
ZachCurtis Jul 16, 2024
4d44b34
Add Vector3:Abs()
ZachCurtis Jul 16, 2024
24b28e5
Add Vector3:Ceil()
ZachCurtis Jul 16, 2024
1a0492d
Add Vector3:Floor()
ZachCurtis Jul 16, 2024
42b736e
Add Vector3:Sign()
ZachCurtis Jul 16, 2024
96e5468
Add Vector2 method tests covering this PR
ZachCurtis Jul 19, 2024
e58bcc0
Add Vector3 method tests covering this PR
ZachCurtis Jul 19, 2024
362c850
Cleanup extra assertion
ZachCurtis Jul 19, 2024
83067d4
Pass epsilon to Vector2:FuzzyEq()
ZachCurtis Jul 19, 2024
7ed75b6
Add Vector3:FuzzyEq() method test
ZachCurtis Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup extra assertion
  • Loading branch information
@ZachCurtis
ZachCurtis committed Jul 19, 2024
commit 362c850b2dfea2f2c1b695b75cbd5b4bdb812987
1 change: 0 additions & 1 deletion tests/roblox/datatypes/Vector2.luau
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ assert(Vector2.new(-1.9, 2.1):Ceil() == Vector2.new(-1, 3))
assert(Vector2.new(-1.1, 2.99):Floor() == Vector2.new(-2, 2))

assert(Vector2.new(1, 2):FuzzyEq(Vector2.new(1 - 1e-6, 2 + 1e-6)))
assert(Vector2.new(1, 2):Angle(Vector2.new(3, 4)))

local angle = Vector2.new(1, 1):Angle(Vector2.new(-1, 1))
assert(math.abs(angle - (math.pi / 2)) < 1e-5)