Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lune will fail to interpret code that begins with a <TAB> #72

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Lune will fail to interpret code that begins with a <TAB> #72

merged 2 commits into from
Jul 19, 2023

Conversation

4x8Matrix
Copy link
Contributor

Context

Calling lua.load with the contents of a file can lead to errors when interpreting file contents. This PR swaps out the original implementation to first compile file contents, and then load the bytecode of the compiled file contents.

This PR

  • Compile script_contents into lua bytecode, then feed the lua bytecode into lua.load function

#70

Copy link
Collaborator

@filiptibell filiptibell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@filiptibell filiptibell merged commit 7237b78 into lune-org:main Jul 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants