Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1955 fix validator setup #1961

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Feb 13, 2019

Closes #1955

Description:

Thank you! 🚀


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #1961 into develop will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #1961      +/-   ##
==========================================
- Coverage    95.18%   95.1%   -0.09%     
==========================================
  Files          121     120       -1     
  Lines         2618    2593      -25     
  Branches       122     122              
==========================================
- Hits          2492    2466      -26     
- Misses         116     117       +1     
  Partials        10      10
Impacted Files Coverage Δ
.../renderer/components/common/TmConnectedNetwork.vue 90% <0%> (-10%) ⬇️
app/src/renderer/vuex/getters.js 94% <0%> (-0.24%) ⬇️
...pp/src/renderer/components/network/PageNetwork.vue 100% <0%> (ø) ⬆️
app/src/renderer/components/common/TmPage.vue 100% <0%> (ø) ⬆️
app/src/renderer/vuex/modules/blocks.js 100% <0%> (ø) ⬆️
app/src/renderer/components/staking/PanelSort.vue 100% <0%> (ø) ⬆️
app/src/renderer/connectors/lcdClient.js 100% <0%> (ø) ⬆️
...nderer/components/transactions/TmLiTransaction.vue 100% <0%> (ø) ⬆️
app/src/renderer/components/network/PageBlock.vue

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit 4d0f3ff into develop Feb 13, 2019
@fedekunze fedekunze deleted the fabo/1955-fix-validator-setup branch February 13, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one validator visible
2 participants