Add parent endpoint method to backend logs. #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent endpoint Signed-off-by: David Hontecillas <dhontecillas@gmail.com>
dhontecillas
force-pushed
the
endpoint_method_info_on_backend_logs
branch
from
4a5f60a
to
82c2090
Compare
kpacha
approved these changes
Feb 16, 2024
dhontecillas
commented
Feb 23, 2024
| @@ -28,7 +28,7 @@ func NewGraphQLMiddleware(logger logging.Logger, remote *config.Backend) Middlew | |||
| if err != nil { | |||
| if err != graphql.ErrNoConfigFound { | |||
| logger.Warning( | |||
| fmt.Sprintf("[BACKEND: %s -> %s][GraphQL] %s", remote.ParentEndpoint, remote.URLPattern, err.Error())) | |||
| fmt.Sprintf("[BACKEND: %s %s -> %s][GraphQL] %s", remote.ParentEndpoint, remote.ParentEndpoint, remote.URLPattern, err.Error())) | |||
There was a problem hiding this comment.
This is wrong, remote.ParentEndpoint -> remote.ParentEndpointMethod
|
This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR: https://github.com/luraproject/lura/pull/702/files , where we added the parent endpoint, I found that we should have added the request method in order uniquely identify the parent endpoint.