feat: add overwrite functionality for invalid Pattern #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @alombarte |
|
Hi @eminaktas , I feel like removing the error management during the validation will bring unintended consequences. |
Do you want to me keep the functioning as it was or just not remove |
eminaktas
force-pushed
the
overwritable-invalidpattern
branch
from
c641b2b
to
d23df8a
Compare
|
@alombarte just added back |
kpacha
requested changes
Mar 12, 2024
eminaktas
force-pushed
the
overwritable-invalidpattern
branch
from
d23df8a
to
7495291
Compare
Signed-off-by: Emin Aktas <eminaktas34@gmail.com>
eminaktas
force-pushed
the
overwritable-invalidpattern
branch
from
7495291
to
dc2ba0e
Compare
|
@kpacha updated as you mentioned. Thanks for the review. |
kpacha
approved these changes
Mar 12, 2024
|
Thanks for the contribution! |
|
This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#710