Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show useful info after a "successful" search #502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

e2298
Copy link

@e2298 e2298 commented Jul 14, 2020

Added some text that points the user towards the "Show unpublished" option after a "successful" search, and, if that option is already ticked, it links them to the game creation page.
I feel this is needed because even if a search returns some results, those results might not be what you're looking for, in which case you might not be aware of these possibilities.
For example, I was looking for "Of orcs and men", which isn't published. However, since "Styx: Master of Shadows" mentions it in its description, I wasn't made aware of the existence of unpublished games, or of the game creation page, and I had to look for help in the discord channel.
I think this patch is a good way to deal with cases like that.

@e2298
Copy link
Author

e2298 commented Jul 14, 2020

This pull request solves this issue:
#492
However, I don't know how to link them. (I'm new to the whole "contributing" thing)

@AlexanderRavenheart
Copy link
Contributor

The ”Submit a new game” button has been re-added a while back (it is right above the filter) so the extra link is redundant.

@e2298
Copy link
Author

e2298 commented Jul 16, 2020

Sure, but I think the reminder to search unpublished games is still useful. I just put the "add a game" link for when that option is already ticked, I think it would look dumb if it told you to look in unpublished when you're already looking in unpublished.

</p>
{% else %}
<p>
Try looking in unpublished games.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users will be confused about this message. A better message would be: Check the ”Show unpublished” option on the filter and click ”Apply filter” to execute the search with the inclusion of unpublished games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants