Skip to content

Commit

Permalink
conf: fix typo in report/columns_as_rows config option name recognition
Browse files Browse the repository at this point in the history
Commit e947c36 introduced
config_settings.h file for central place to store all definitions for
config options. By mistake, it used report/colums_as_rows instead
of report/columns_as_rows (missing "n" in "columns").
  • Loading branch information
prajnoha committed Aug 25, 2016
1 parent b0e07d5 commit e758d72
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions WHATS_NEW
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Version 2.02.165 -
===================================
Fix typo in report/columns_as_rows config option name recognition (2.02.99).
Avoid PV tags when checking allocation against parallel PVs.
Disallow mirror conversions of raid10 volumes.
Fix dmeventd unmonitoring when segment type (and dso) changes.
Expand Down
2 changes: 1 addition & 1 deletion conf/command_profile_template.profile.in
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ report {
list_item_separator=","
prefixes=0
quoted=1
colums_as_rows=0
columns_as_rows=0
binary_values_as_numeric=0
time_format="%Y-%m-%d %T %z"
devtypes_sort="devtype_name"
Expand Down
2 changes: 1 addition & 1 deletion lib/config/config_settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -1571,7 +1571,7 @@ cfg(report_prefixes_CFG, "prefixes", report_CFG_SECTION, CFG_PROFILABLE | CFG_DE
cfg(report_quoted_CFG, "quoted", report_CFG_SECTION, CFG_PROFILABLE | CFG_DEFAULT_COMMENTED, CFG_TYPE_BOOL, DEFAULT_REP_QUOTED, vsn(2, 2, 39), NULL, 0, NULL,
"Quote field values when using field name prefixes.\n")

cfg(report_colums_as_rows_CFG, "colums_as_rows", report_CFG_SECTION, CFG_PROFILABLE | CFG_DEFAULT_COMMENTED, CFG_TYPE_BOOL, DEFAULT_REP_COLUMNS_AS_ROWS, vsn(1, 0, 0), NULL, 0, NULL,
cfg(report_columns_as_rows_CFG, "columns_as_rows", report_CFG_SECTION, CFG_PROFILABLE | CFG_DEFAULT_COMMENTED, CFG_TYPE_BOOL, DEFAULT_REP_COLUMNS_AS_ROWS, vsn(1, 0, 0), NULL, 0, NULL,
"Output each column as a row.\n"
"If set, this also implies report/prefixes=1.\n")

Expand Down
2 changes: 1 addition & 1 deletion tools/reporter.c
Original file line number Diff line number Diff line change
Expand Up @@ -1237,7 +1237,7 @@ static int _config_report(struct cmd_context *cmd, struct report_args *args, str
args->separator = find_config_tree_str(cmd, report_separator_CFG, NULL);
args->field_prefixes = find_config_tree_bool(cmd, report_prefixes_CFG, NULL);
args->quoted = find_config_tree_bool(cmd, report_quoted_CFG, NULL);
args->columns_as_rows = find_config_tree_bool(cmd, report_colums_as_rows_CFG, NULL);
args->columns_as_rows = find_config_tree_bool(cmd, report_columns_as_rows_CFG, NULL);

/* Check PV specifics and do extra changes/actions if needed. */
_check_pv_list(cmd, args, single_args);
Expand Down

0 comments on commit e758d72

Please sign in to comment.