Skip to content

Commit

Permalink
Uncomment annotation change
Browse files Browse the repository at this point in the history
Uncomment change of annotation for the case when more resources have
been estimated, but there is no lag. Without this annotation update,
instances could be stuck in "PENDING_SCALING_UP".
  • Loading branch information
lwolf committed Nov 16, 2022
1 parent 5acfcf7 commit 1f560ae
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions controllers/operator.go
Original file line number Diff line number Diff line change
Expand Up @@ -434,10 +434,7 @@ func (o *operator) estimateDeploy(deploy *appsv1.Deployment) (*appsv1.Deployment
logHeadline = fmt.Sprintf("No action. More resources estimated, but instance is SATURATED")
}
} else {
// XXX: changing annotation here doesn't make any sense.
// current state is: pod is running, no lag detected, but estimations thinks that it needs more resources
// this leads to changing state from RUNNING to SATURATED ?!
// isChangedAnnotations = o.updateScaleAnnotations(deploy, underProvision)
isChangedAnnotations = o.updateScaleAnnotations(deploy, underProvision)
logHeadline = fmt.Sprintf("No action. More resources estimated, but no lag detected")
}
case cmpResourcesLt:
Expand Down

0 comments on commit 1f560ae

Please sign in to comment.