Update 1 21 2018 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a `download_dir` will make `pip` export the cloned repo via `reqset._prepare_file` and `git-checkout-index`, which then makes `python setup.py egg_info` fail, when [setuptools_scm](https://github.com/pypa/setuptools_scm) is used. Fixes jazzband#369.
The first line of is_pinned_requirement() checks the value of editable, don't need to do so on the same line as the call.
Removes spurious output when running tests.
Add Python 3.6 to the tox test matrix
Remove redundant check for editable
No download dir for editable
Remove prints used during debugging from tests
Fixing OutputWriter._iter_lines for pip 8.1.1 or below
Add dates to changelog
Pip sync quiet
…apitalized-primary-packages Remove unwanted annotations from primary packages
Ignore pkg-resources in pip-sync
…d-reqs Document that pip-sync should only be used with compiled requirements.txt
Allow for CA bundles in CLI for pip-compile (rebased jazzband#365)
Add '-markerlib' to the PACKAGES_TO_IGNORE
…message Slightly improved NoCandidateFound error message.
And other assorted formatting/language tweaks.
Allow editable packages in requirements.in when using --generate-hashes
Recommend installation into virtual environment
Added Appveyor and PyPi badges
_compat/__init__.py already handles the differences between Python 2 & 3
with the code:
if six.PY2:
from .tempfile import TemporaryDirectory
...
else:
from tempfile import TemporaryDirectory
...
There is no reason to redo this logic in files importing TemporaryDirectory.
More idiomatic use of open().
Always use _compat to import TemporaryDirectory
Always prefer open()'s context manager
This test takes a very long time, because it downloads Django from GitHub. There should be no reason to do that, since we can use local packages as well.
tests: Do not download Django from Git
If pytest is ran with "--doctest-modules" option, then the test dist packages under the "fixtures" directory should be ignored, because otherwise pytest tries to import the "setup.py" files and fails. The name "fixtures" suggests that it could also contain some Python code that shouldn't be ignored by pytest, but currently it contains only test data, such as fake PyPI index, test dist packages and test wheels. Rename the "fixtures" directory to "test_data" so that it can be marked to be ignored by pytest without risking ignoring too much.
tox.ini: Configure Tox to run the pytest with doctests. setup.cfg: Configure pytest to ignore fake_pypi when collecting tests, because collecting the setup.py files in fake_pypi causes problems, since pytest imports and runs them when collecting.
Fix doctests and run them with tox
Helps pip decide what version of the library to install. https://packaging.python.org/tutorials/distributing-packages/#python-requires > If your project only runs on certain Python versions, setting the > python_requires argument to the appropriate PEP 440 version specifier > string will prevent pip from installing the project on other Python > versions. https://setuptools.readthedocs.io/en/latest/setuptools.html#new-and-changed-setup-keywords > python_requires > > A string corresponding to a version specifier (as defined in PEP 440) > for the Python version, used to specify the Requires-Python defined in > PEP 345.
Fix capitalization: PyPi -> PyPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring lyft's fork of pip-tools up to date with upstream master.