Remove tag_name redefinition from "enforce_system_properties" rule #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was included by mistake and is unnecessary for current uses as the element's tag will the equivalent to the original tag_name that was used for the search. However, by removing it we can now use nested types.
I added an example of enforcing properties for a stackView's color. This triggers on the following example:
```
<stackView opaque="NO" contentMode="scaleToFill" id="zvX-8E-dZy">
<color key="backgroundColor" name="+ Background Primary"/>
[...]
</stackView>
```
|
cc @keith |
keith
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was included by mistake and is unnecessary for current uses because the element's tag will equivalent to the original tag_name that was used for the search. By removing it we can now use nested types in the element search.
I added an example of enforcing properties for a stackView's color. This triggers on the following code: