Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 深色模式切换异常 #1697

Closed
2 tasks done
yours57 opened this issue Nov 17, 2023 · 2 comments
Closed
2 tasks done

[Bug]: 深色模式切换异常 #1697

yours57 opened this issue Nov 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@yours57
Copy link

yours57 commented Nov 17, 2023

解决方案检查

预期行为

如题,主题的自动切换异常,不会随着系统自动切换浅、深色主题,除非完整退出应用然后重新打开。

查看log发现有如下报错,不知是否有关
[2023-11-17 10:53:33.254] [error] TypeError: Cannot read properties of undefined (reading 'shouldUseDarkColors')
at NativeTheme. (D:\Tools\lx-music\resources\app.asar\dist\main.js:49696:60)
at NativeTheme.emit (node:events:513:28)
[2023-11-17 10:53:33.269] [error] TypeError: Cannot read properties of undefined (reading 'shouldUseDarkColors')
at NativeTheme. (D:\Tools\lx-music\resources\app.asar\dist\main.js:49696:60)
at NativeTheme.emit (node:events:513:28)
[2023-11-17 10:53:33.281] [error] TypeError: Cannot read properties of undefined (reading 'shouldUseDarkColors')
at NativeTheme. (D:\Tools\lx-music\resources\app.asar\dist\main.js:49696:60)
at NativeTheme.emit (node:events:513:28)
[2023-11-17 10:55:07.033] [error] TypeError: Cannot read properties of undefined (reading 'shouldUseDarkColors')
at NativeTheme. (D:\Tools\lx-music\resources\app.asar\dist\main.js:49696:60)
at NativeTheme.emit (node:events:513:28)
[2023-11-17 10:55:55.274] [error] TypeError: Cannot read properties of undefined (reading 'shouldUseDarkColors')
at NativeTheme. (D:\Tools\lx-music\resources\app.asar\dist\main.js:49696:60)
at NativeTheme.emit (node:events:513:28)
[2023-11-17 10:55:55.278] [error] TypeError: Cannot read properties of undefined (reading 'shouldUseDarkColors')
at NativeTheme. (D:\Tools\lx-music\resources\app.asar\dist\main.js:49696:60)
at NativeTheme.emit (node:events:513:28)
[2023-11-17 10:56:09.086] [error] TypeError: Cannot read properties of undefined (reading 'shouldUseDarkColors')
at NativeTheme. (D:\Tools\lx-music\resources\app.asar\dist\main.js:49696:60)
at NativeTheme.emit (node:events:513:28)
[2023-11-17 10:56:09.190] [error] TypeError: Cannot read properties of undefined (reading 'shouldUseDarkColors')
at NativeTheme. (D:\Tools\lx-music\resources\app.asar\dist\main.js:49696:60)
at NativeTheme.emit (node:events:513:28)
[2023-11-17 10:56:09.207] [error] TypeError: Cannot read properties of undefined (reading 'shouldUseDarkColors')
at NativeTheme. (D:\Tools\lx-music\resources\app.asar\dist\main.js:49696:60)
at NativeTheme.emit (node:events:513:28)
[2023-11-17 10:56:11.118] [error] TypeError: Cannot read properties of undefined (reading 'shouldUseDarkColors')
at NativeTheme. (D:\Tools\lx-music\resources\app.asar\dist\main.js:49696:60)
at NativeTheme.emit (node:events:513:28)

实际行为

跟随系统自动切换主题

Lx Music 版本

2.5.0

最后正常的版本

2.4.0

操作系统版本

win 23H2

附加信息

No response

@lyswhut lyswhut added the bug Something isn't working label Nov 17, 2023
@lyswhut
Copy link
Owner

lyswhut commented Nov 17, 2023

v2.5.0没动这块功能的代码,应该是更新到新版electron的系统主题颜色切换事件参数变更导致的,下个版本修复

@lyswhut
Copy link
Owner

lyswhut commented Feb 1, 2024

已在v2.6.0修复

@lyswhut lyswhut closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants