fix #731 #887，修复桌面歌词与主窗口阴影残留 #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我之前没注意到electron提供了这个选项，而且是这个选项在MacOS上导致出现残留阴影的罪魁祸首，事实上程序并不需要系统绘制窗口阴影，程序自己实现了窗口阴影，这应该就是你取消了窗口阴影仍然正常工作的原因，感谢你的PR ❤️，我晚点抽空再做些修改彻底解决这个问题😀 |
|
非常感谢您的辛苦付出❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lyswhut 你好，根据electron的说法，这个bug仅出现在mac的透明窗口中。桌面台词窗口就是这种窗口，该修复在mac下取消了该窗口的阴影效果。相较于invalidShadow()这种延迟清理的做法，直接取消阴影效果感觉更舒服。对于主窗口采取了同样的方案。
以下是修改后的效果：
桌面歌词不会有阴影残留了，感觉还不错。
主窗口虽然取消了阴影，可能macos会自动为窗体创建阴影，依然有阴影效果。
修改后不影响其他系统用户。