Skip to content

Commit

Permalink
Revert "Bump go to 1.14 (#2853)" (#2885)
Browse files Browse the repository at this point in the history
We'll upgrade Go runtime immediately after 1.0 release, we're still waiting on a few more end users to sign off on performance under Go 1.14 (we'll likely move directly to evaluating performance under Go 1.15 with end users instead).
  • Loading branch information
vdarulis authored and robskillington committed Nov 12, 2020
1 parent ba6a303 commit 3cf877e
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 13 deletions.
8 changes: 4 additions & 4 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ steps:
command: make clean install-vendor-m3 test-all-gen
env:
CGO_ENABLED: 0
GIMME_GO_VERSION: 1.14.x
GIMME_GO_VERSION: 1.13.x
plugins:
gopath-checkout#v1.0.1:
import: github.com/m3db/m3
Expand Down Expand Up @@ -56,7 +56,7 @@ steps:
parallelism: 2
env:
CGO_ENABLED: 0
GIMME_GO_VERSION: 1.14.x
GIMME_GO_VERSION: 1.13.x
plugins:
gopath-checkout#v1.0.1:
import: github.com/m3db/m3
Expand All @@ -66,7 +66,7 @@ steps:
parallelism: 1
env:
CGO_ENABLED: 0
GIMME_GO_VERSION: 1.14.x
GIMME_GO_VERSION: 1.13.x
plugins:
gopath-checkout#v1.0.1:
import: github.com/m3db/m3
Expand Down Expand Up @@ -99,7 +99,7 @@ steps:
command: make clean install-vendor-m3 docs-test
env:
CGO_ENABLED: 0
GIMME_GO_VERSION: 1.14.x
GIMME_GO_VERSION: 1.13.x
plugins:
gopath-checkout#v1.0.1:
import: github.com/m3db/m3
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ GO_BUILD_LDFLAGS_CMD := $(abspath ./scripts/go-build-ldflags.sh)
GO_BUILD_LDFLAGS := $(shell $(GO_BUILD_LDFLAGS_CMD) LDFLAG)
GO_BUILD_COMMON_ENV := CGO_ENABLED=0
LINUX_AMD64_ENV := GOOS=linux GOARCH=amd64 $(GO_BUILD_COMMON_ENV)
# GO_RELEASER_DOCKER_IMAGE is latest goreleaser for go 1.14
GO_RELEASER_DOCKER_IMAGE := goreleaser/goreleaser:v0.141.0
# GO_RELEASER_DOCKER_IMAGE is latest goreleaser for go 1.13
GO_RELEASER_DOCKER_IMAGE := goreleaser/goreleaser:v0.127.0
GO_RELEASER_RELEASE_ARGS ?= --rm-dist
GO_RELEASER_WORKING_DIR := /go/src/github.com/m3db/m3

Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
app:
image: golang:1.14-stretch
image: golang:1.13-stretch
volumes:
- .:/go/src/github.com/m3db/m3
- /usr/bin/buildkite-agent:/usr/bin/buildkite-agent
Expand Down
2 changes: 1 addition & 1 deletion docker/m3aggregator/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# stage 1: build
FROM golang:1.14-alpine3.11 AS builder
FROM golang:1.13-alpine3.11 AS builder
LABEL maintainer="The M3DB Authors <m3db@googlegroups.com>"

# Install deps
Expand Down
2 changes: 1 addition & 1 deletion docker/m3collector/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# stage 1: build
FROM golang:1.14-alpine3.11 AS builder
FROM golang:1.13-alpine3.11 AS builder
LABEL maintainer="The M3DB Authors <m3db@googlegroups.com>"

# Install deps
Expand Down
2 changes: 1 addition & 1 deletion docker/m3coordinator/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# stage 1: build
FROM golang:1.14-alpine3.11 AS builder
FROM golang:1.13-alpine3.11 AS builder
LABEL maintainer="The M3DB Authors <m3db@googlegroups.com>"

# Install deps
Expand Down
2 changes: 1 addition & 1 deletion docker/m3dbnode/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# stage 1: build
FROM golang:1.14-alpine3.11 AS builder
FROM golang:1.13-alpine3.11 AS builder
LABEL maintainer="The M3DB Authors <m3db@googlegroups.com>"

# Install deps
Expand Down
2 changes: 1 addition & 1 deletion docker/m3dbnode/Dockerfile-setcap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# stage 1: build
FROM golang:1.14-alpine3.11 AS builder
FROM golang:1.13-alpine3.11 AS builder
LABEL maintainer="The M3DB Authors <m3db@googlegroups.com>"

# Install deps
Expand Down
2 changes: 1 addition & 1 deletion docker/m3query/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# stage 1: build
FROM golang:1.14-alpine3.11 AS builder
FROM golang:1.13-alpine3.11 AS builder
LABEL maintainer="The M3DB Authors <m3db@googlegroups.com>"

# Install deps
Expand Down

0 comments on commit 3cf877e

Please sign in to comment.