[dbnode/index] postingsList caching for FieldQuery #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird about the code cov dropping so much? Probably a bug with the reporting I suppose? |
richardartoul
approved these changes
Apr 4, 2019
| case PatternTypeField: | ||
| q.metrics.field.puts.Inc(1) | ||
| default: | ||
| q.metrics.unknown.puts.Inc(1) |
There was a problem hiding this comment.
super nit: Can you add a "should never happen" under the default case so it doesnt seem like thats something that might happen regularly
| return s.reader.MatchField(field) | ||
| } | ||
|
|
||
| // TODO(rartoul): Would be nice to not allocate strings here. |
There was a problem hiding this comment.
yeah making me look even lazier :P
prateek
force-pushed
the
prateek/dbnode/field-query-plcache
branch
from
fe30a69
to
f96935f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1530 +/- ##
======================================
Coverage 70.2% 70.2%
======================================
Files 851 851
Lines 73030 73030
======================================
Hits 51271 51271
Misses 18325 18325
Partials 3434 3434
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.