Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update namespace_configuration docs to use the right keys #2045

Merged
merged 6 commits into from
Nov 26, 2019

Conversation

bpownow
Copy link
Contributor

@bpownow bpownow commented Nov 15, 2019

What this PR does / why we need it:

Fixes #

Does this PR introduce a user-facing and/or backwards incompatible change?: No


Does this PR require updating code package or user-facing documentation?: This is a documentation update.


@bpownow bpownow changed the title Update namespace_configuration.md update namespace_configuration docs Nov 15, 2019
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2019

CLA assistant check
All committers have signed the CLA.

@bpownow bpownow changed the title update namespace_configuration docs update namespace_configuration docs to use the right keys Nov 15, 2019
"blockDataExpiry": true,
"blockDataExpiryAfterNotAccessPeriodDuration": "5m"
"blockDataExpiryAfterNotAccessPeriod": "5m"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may have to be blockDataExpiryAfterNotAccessedPeriod as here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnikola updated

@arnikola arnikola added the ci Triggers CI (useful for external contributors) label Nov 25, 2019
@schallert schallert removed the ci Triggers CI (useful for external contributors) label Nov 25, 2019
@arnikola arnikola added area:aggregator All issues pertaining to aggregator ci Triggers CI (useful for external contributors) labels Nov 25, 2019
@schallert schallert removed the ci Triggers CI (useful for external contributors) label Nov 25, 2019
@arnikola arnikola removed the area:aggregator All issues pertaining to aggregator label Nov 25, 2019
@bpownow
Copy link
Contributor Author

bpownow commented Nov 26, 2019

@arnikola Can we merge this?

@arnikola
Copy link
Collaborator

Yeah sorry, new stuff keeps coming in before I get a chance to merge :p

@arnikola arnikola merged commit 6f2ecf5 into m3db:master Nov 26, 2019
@arnikola
Copy link
Collaborator

Thanks again, merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants