Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Add aggregator client maxBatchSize config for bigger buffer for data sent to aggregator #2166

Merged
merged 3 commits into from
Feb 24, 2020

Conversation

robskillington
Copy link
Collaborator

@robskillington robskillington commented Feb 24, 2020

What this PR does / why we need it:

The default was also vastly too small for workloads with a lot of metrics being sent to a single aggregator instance.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Collaborator

@martin-mao martin-mao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington merged commit 7e3859c into master Feb 24, 2020
@robskillington robskillington deleted the r/add-max-batch-size branch February 24, 2020 07:54
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2166 into master will decrease coverage by <.1%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2166     +/-   ##
========================================
- Coverage    72.3%   72.3%   -0.1%     
========================================
  Files        1016    1016             
  Lines       87979   87981      +2     
========================================
- Hits        63665   63661      -4     
- Misses      20047   20055      +8     
+ Partials     4267    4265      -2
Flag Coverage Δ
#aggregator 82% <0%> (ø) ⬆️
#cluster 85.3% <ø> (-0.1%) ⬇️
#collector 82.8% <ø> (ø) ⬆️
#dbnode 79.3% <ø> (-0.1%) ⬇️
#m3em 74.4% <ø> (ø) ⬆️
#m3ninx 74.2% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.8% <ø> (-0.2%) ⬇️
#query 68.3% <ø> (ø) ⬆️
#x 83.1% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cdacd3...bace1cf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants