Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add set placement endpoint docs #2183

Merged
merged 6 commits into from
Feb 29, 2020
Merged

Conversation

benraskin92
Copy link
Collaborator

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #2183 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2183     +/-   ##
========================================
+ Coverage    72.2%   72.3%   +0.1%     
========================================
  Files        1017    1016      -1     
  Lines       88265   88056    -209     
========================================
- Hits        63739   63693     -46     
+ Misses      20239   20086    -153     
+ Partials     4287    4277     -10
Flag Coverage Δ
#aggregator 82% <0%> (ø) ⬆️
#cluster 85.2% <0%> (-0.2%) ⬇️
#collector 82.8% <0%> (ø) ⬆️
#dbnode 79.2% <0%> (+0.2%) ⬆️
#m3em 74.4% <0%> (ø) ⬆️
#m3ninx 74.2% <0%> (+46.9%) ⬆️
#m3nsch 51.1% <0%> (ø) ⬆️
#metrics 17.6% <0%> (ø) ⬆️
#msg 74.9% <0%> (+0.1%) ⬆️
#query 68.3% <0%> (+0.1%) ⬆️
#x 83% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c69bc6...7eeaac0. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #2183 into master will decrease coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2183     +/-   ##
========================================
- Coverage    72.3%   71.8%   -0.5%     
========================================
  Files        1016    1016             
  Lines       88056   88056             
========================================
- Hits        63701   63309    -392     
- Misses      20082   20504    +422     
+ Partials     4273    4243     -30     
Flag Coverage Δ
#aggregator 82.0% <ø> (-0.1%) ⬇️
#cluster 85.2% <ø> (-0.2%) ⬇️
#collector 82.8% <ø> (ø) ⬆️
#dbnode 79.2% <ø> (+<0.1%) ⬆️
#m3em 74.4% <ø> (ø) ⬆️
#m3ninx 63.6% <ø> (-10.7%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 52.2% <ø> (+34.5%) ⬆️
#msg 74.8% <ø> (-0.3%) ⬇️
#query 68.3% <ø> (ø) ⬆️
#x 83.0% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94054f2...0ebc638. Read the comment docs.

@benraskin92 benraskin92 marked this pull request as ready for review February 29, 2020 14:01
@benraskin92 benraskin92 changed the title [docs][DRAFT] Add set placement endpoint docs [docs] Add set placement endpoint docs Feb 29, 2020
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than minor bit about removing mention of “seed node” and just mentioning “nodes”

docs/operational_guide/placement_configuration.md Outdated Show resolved Hide resolved
@benraskin92 benraskin92 merged commit bf81308 into master Feb 29, 2020
@benraskin92 benraskin92 deleted the braskin/placement_set_docs branch February 29, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants