Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Decode avoid checked bytes in segment reader #2190

Merged
merged 20 commits into from
Mar 7, 2020

Conversation

rallen090
Copy link
Collaborator

@rallen090 rallen090 commented Mar 3, 2020

What this PR does / why we need it:

Targeting the unchecked byte reads
image

Looks like a ~7% improvement in the small-byte-count case (e.g. benchmark on 10 instead of 2000).

PRE
BenchmarkNextIteration/series_10-12                 2047            534476 ns/op
BenchmarkNextIteration/series_2000-12                193           9585290 ns/op
POST
BenchmarkNextIteration/series_10-12                 2197            557157 ns/op
BenchmarkNextIteration/series_2000-12                237           4950101 ns/op

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #2190 into master will decrease coverage by 0.9%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #2190    +/-   ##
=======================================
- Coverage    72.2%   71.3%    -1%     
=======================================
  Files        1019    1019            
  Lines       88430   88433     +3     
=======================================
- Hits        63916   63116   -800     
- Misses      20234   20982   +748     
- Partials     4280    4335    +55
Flag Coverage Δ
#aggregator 82% <ø> (-0.1%) ⬇️
#cluster 85.2% <ø> (-0.2%) ⬇️
#collector 82.8% <ø> (ø) ⬆️
#dbnode 76.8% <100%> (-2.3%) ⬇️
#m3em 74.4% <ø> (ø) ⬆️
#m3ninx 74.6% <ø> (-0.2%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 68.1% <ø> (ø) ⬆️
#x 83.4% <ø> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7228d90...553126e. Read the comment docs.

Copy link
Collaborator

@arnikola arnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnikola arnikola changed the title Decode avoid checked bytes in segment reader [dbnode] Decode avoid checked bytes in segment reader Mar 6, 2020
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington merged commit 77cfec4 into master Mar 7, 2020
@robskillington robskillington deleted the ra/decode-checked-bytes branch March 7, 2020 02:59
rallen090 added a commit that referenced this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants