Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Use madvdontneed=1 for GODEBUG flags #2242

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

This keeps memory profile lower at the expense slightly slower allocation speed. Since we memory pool a lot of our data structures we don't usually face the allocation slow down, we'd prefer lower memory profiles with larger heap sizes.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Collaborator

@arnikola arnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington merged commit 8d40fbd into master Apr 2, 2020
@justinjc justinjc deleted the r/use-madvdontneed branch May 14, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants