[dbnode] Default HostID and Discovery config for minimal config #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbdu
approved these changes
Nov 11, 2020
notbdu
reviewed
Nov 11, 2020
| @@ -166,7 +175,7 @@ type DBConfiguration struct { | |||
| PoolingPolicy *PoolingPolicy `yaml:"pooling"` | |||
|
|
|||
| // The discovery configuration. | |||
| DiscoveryConfig discovery.Configuration `yaml:"discovery"` | |||
| Discovery *discovery.Configuration `yaml:"discovery"` | |||
There was a problem hiding this comment.
Looks like we need to change this in a few places as well.
robskillington
added a commit
that referenced
this pull request
Nov 12, 2020
soundvibe
added a commit
that referenced
this pull request
Nov 12, 2020
* master: [query] Remove dead code in prom package (#2871) Improve some slow tests (#2881) [coordinator] Set default namespace tag to avoid colliding with commonly used "namespace" label (#2878) [dbnode] Introduce Aggregator type (#2840) [dbnode] Refactor wide query path (#2826) [dbnode] Add validation to ensure index claims is singleton (#2877) [dbnode] Default HostID and Discovery config for minimal config (#2876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Default HostID and Discovery config for a minimal configuration file for default DB node which ends up being:
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: