Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coordinator] Simplify iteration logic of matchRollupTarget #3321

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

wesleyk
Copy link
Collaborator

@wesleyk wesleyk commented Mar 4, 2021

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #3321 (0a7354b) into master (bffb7aa) will decrease coverage by 0.0%.
The diff coverage is 33.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3321     +/-   ##
=========================================
- Coverage    72.4%    72.4%   -0.1%     
=========================================
  Files        1099     1099             
  Lines      101617   101614      -3     
=========================================
- Hits        73672    73659     -13     
- Misses      22864    22872      +8     
- Partials     5081     5083      +2     
Flag Coverage Δ
aggregator 76.5% <ø> (+0.6%) ⬆️
cluster 84.9% <ø> (ø)
collector 84.3% <ø> (ø)
dbnode 78.9% <ø> (-0.1%) ⬇️
m3em 74.4% <ø> (ø)
m3ninx 73.5% <ø> (-0.1%) ⬇️
metrics 20.0% <33.3%> (-0.1%) ⬇️
msg 74.2% <ø> (+0.3%) ⬆️
query 67.4% <ø> (ø)
x 80.5% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bffb7aa...0a7354b. Read the comment docs.

@wesleyk wesleyk merged commit 100b867 into master Mar 4, 2021
@wesleyk wesleyk deleted the wesley-iterate branch March 4, 2021 04:29
soundvibe added a commit that referenced this pull request Mar 9, 2021
* master: (22 commits)
  Remove deprecated fields (#3327)
  Add quotas to Permits (#3333)
  [aggregator] Drop messages that have a drop policy applied (#3341)
  Fix NPE due to race with a closing series (#3056)
  [coordinator] Apply auto-mapping rules if-and-only-if no drop policies are in effect (#3339)
  [aggregator] Add validation in AddTimedWithStagedMetadatas (#3338)
  [coordinator] Fix panic in Ready endpoint for admin coordinator (#3335)
  [instrument] Config option to emit detailed Go runtime metrics only (#3332)
  [aggregator] Sort heap in one go, instead of iterating one-by-one (#3331)
  [pool] Add support for dynamic, sync.Pool backed, object pools (#3334)
  Enable PANIC_ON_INVARIANT_VIOLATED for tests (#3326)
  [aggregator] CanLead for unflushed window takes BufferPast into account (#3328)
  Optimize StagedMetadatas conversion (#3330)
  [m3msg] Improve message scan performance (#3319)
  [dbnode] Add reason tag to bootstrap retries metric (#3317)
  [coordinator] Enable rule filtering on prom metric type (#3325)
  Update m3dbnode-all-config.yml (#3204)
  [coordinator] Include Type in RollupOp.Equal (#3322)
  [coordinator] Simplify iteration logic of matchRollupTarget (#3321)
  [coordinator] Add rollup type to remove specific dimensions (#3318)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants