Use lower per db instance limits for aggregate and fetchTaggedIDs #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has worked well for the FetchTagged endpoint, so rolling out to the Aggregate and FetchTaggedIDs endpoints as well.
Codecov Report
@@ Coverage Diff @@
## master #3527 +/- ##
========================================
- Coverage 55.9% 55.9% -0.1%
========================================
Files 548 548
Lines 61380 61393 +13
========================================
- Hits 34360 34330 -30
- Misses 23915 23953 +38
- Partials 3105 3110 +5
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
wesleyk
reviewed
May 27, 2021
| // mock the host queue to return a result with a single series, this results in 3 series total, one per shard. | ||
| sess := setupMultipleInstanceCluster(t, ctrl, func(op op, host topology.Host) { | ||
| aOp := op.(*aggregateOp) | ||
| assert.Equal(t, int64(2), *aOp.request.SeriesLimit) |
There was a problem hiding this comment.
really this is the assertion we care about right?
There was a problem hiding this comment.
This verifies the correct limit was sent. The assertion at the end verifies the results are properly accumulated across shards, with 1 result from each shard for a total of 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has worked well for the FetchTagged endpoint, so rolling out to the
Aggregate and FetchTaggedIDs endpoints as well.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: