Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes, changes, and modularizing #15

Merged
merged 5 commits into from
Apr 3, 2018
Merged

Conversation

andyshinn
Copy link
Contributor

This also supersedes #13. The biggest thing to note here is that it removes the use of deprecated include and uses import_tasks which is a Ansible 2.4+ feature. It would make sense to bump the major version of this on Ansible Galaxy if this is merged.

Some of the changes happening here:

  • Joining networks and authorizing nodes are now separate actions. They run when zerotier_accesstoken or zerotier_network_id are set.
  • Variables zerotier_accesstoken and zerotier_network_id are now optional and control whether a node is authorized or it is joined to a network respectively.
  • In my setup I preferred to use the short name so I have added an option for zerotier_register_short_hostname. It defaults to false to retain the existing behavior.
  • I changed the curl tasks to use the url module instead. This should negate the need for curl on the hosts.
  • Modularized some of the tasks to use import_tasks (static) and include_tasks (dynamic) new directives of Ansible 2.4.

m4rcu5nl and others added 5 commits January 29, 2018 22:29
Fresh install was failing if the zerotier repo did not exist. Changed the initial check to check the existence of the zerotier repo file.
Update install.yml to fix fresh Debian install.
@m4rcu5nl m4rcu5nl self-assigned this Apr 2, 2018
@m4rcu5nl m4rcu5nl merged commit 401536c into m4rcu5nl:develop Apr 3, 2018
@m4rcu5nl m4rcu5nl mentioned this pull request Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants