Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sudo for install and zerotier-cli commands #24

Closed
wants to merge 1 commit into from
Closed

Add sudo for install and zerotier-cli commands #24

wants to merge 1 commit into from

Conversation

finchd
Copy link

@finchd finchd commented Nov 30, 2018

The role as of v1.1.0 or commit:89c5635 (master) didn't work for me on Ubuntu 18.04 Bionic, every apt and zerotier-cli step needed become: yes.

This PR adds become: yes to the main.yml where install and join_network tasklists get included as all of their tasks require sudo, and adds one use in authorize_node.yml because of one usage of the zerotier-cli.

Note: Your role is unlicensed. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@m4rcu5nl m4rcu5nl changed the base branch from master to develop December 1, 2018 06:37
@m4rcu5nl
Copy link
Owner

m4rcu5nl commented Dec 1, 2018

Hi. Thanks for the PR but this is more or less by design. The idea is to leave environment specific choices as much as possible in the playbook. The role only specifically drops privileges to do the api requests as the local user. This makes it possible to include it in your playbook as follows:

    roles:
         - { role: m4rcu5nl.zerotier, become: true }

I've updated the example in the README to reflect this.

@m4rcu5nl m4rcu5nl closed this Dec 1, 2018
@finchd finchd deleted the finchd-become branch January 2, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants