fix for TFT_eSPI_Button compatibility mode #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinyu-Zhao
added a commit
that referenced
this pull request
Jul 3, 2024
fix for TFT_eSPI_Button compatibility mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TFT_eSPI_Button compatibility mode was half-baked and apparently untested:
TFT_eSPI_Button::justPressed()andTFT_eSPI_Button::justReleaed()always returned true 🤦With this patch, TFT_eSPI_Button does not use the
::contains()and::isPressed()methods from the inherited (and failing)Buttonobject.