MINOR: log connect reconfiguration error only if there was an error

Author: Gwen Shapira <cshapi@gmail.com> Reviewers: Ewen Cheslack-Postava <ewen@confluent.io> Closes apache#871 from gwenshap/fix-cc-log
mabulgu · Feb 4, 2016 · 9b47f9a · 9b47f9a
1 parent 0a7b20e
commit 9b47f9a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java b/...runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
@@ -455,8 +455,10 @@ public Void call() throws Exception {
                 new Callback<Void>() {
                     @Override
                     public void onCompletion(Throwable error, Void result) {
-                        log.error("Unexpected error during task reconfiguration: ", error);
-                        log.error("Task reconfiguration for {} failed unexpectedly, this connector will not be properly reconfigured unless manually triggered.", connName);
+                        if (error != null) {
+                            log.error("Unexpected error during task reconfiguration: ", error);
+                            log.error("Task reconfiguration for {} failed unexpectedly, this connector will not be properly reconfigured unless manually triggered.", connName);
+                        }
                     }
                 }
         );