Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite-only system no longer working #26

Open
aendra-rininsland opened this issue Feb 18, 2014 · 4 comments
Open

Invite-only system no longer working #26

aendra-rininsland opened this issue Feb 18, 2014 · 4 comments

Comments

@aendra-rininsland
Copy link

Howdy!

It seems the invite system was partially removed in commit cdf602d. Part of what made me interested in using this project in the first place was the invite system, and it's kinda confusing that there are still relics from that (Limited invites, columns in the User model).

Suggested resolution:

  • Re-add the invite system in a more modular fashion, such that it can be turned off and on via config option.
  • Failing that, remove the constrained invitation system (I.e., give users unlimited invites).
  • Create a branch for using the invitation system, such as is suggested used to be the case in Dan's amazing Heroku blogpost.
@maccman
Copy link
Owner

maccman commented Feb 18, 2014

Yup, I half/removed the invite system (not very cleanly). Apologies.
Definitely happy with a config option for invites.

On Tue, Feb 18, 2014 at 11:32 AM, Ændrew Rininsland <
notifications@github.com> wrote:

Howdy!

It seems the invite system was partially removed in commit cdf602dhttps://github.com/maccman/monocle/commit/cdf602df869fd1073502466644079564b759093f.
Part of what made me interested in using this project in the first place
was the invite system, and it's kinda confusing that there are still relics
from that (Limited invites, columns in the User model).

Suggested resolution:

  • Re-add the invite system in a more modular fashion, such that it can
    be turned off and on via config option.
  • Failing that, remove the constrained invitation system (I.e., give
    users unlimited invites).

Reply to this email directly or view it on GitHubhttps://github.com//issues/26
.

Alex MacCaw

+1.415.624.7665
@maccaw

http://alexmaccaw.com

@aendra-rininsland
Copy link
Author

@maccman No worries! Found the commit where it was done, doesn't seem like it'd be too much work to re-add it with config options. Thanks for getting back to me!

My inexperience with Ruby may be a bit apparent with this, but any particular place where you're doing global config already? Or is it all just env vars? If just env vars, I'll continue in that vein.

@maccaw
Copy link

maccaw commented Feb 19, 2014

ENV var read from app.rb

On Tue, Feb 18, 2014 at 2:20 PM, Ændrew Rininsland <notifications@github.com

wrote:

@maccman https://github.com/maccman No worries! Found the commit where
it was done, doesn't seem like it'd be too much work to re-add it with
config options. Thanks for getting back to me!

My inexperience with Ruby may be a bit apparent with this, but any
particular place where you're doing global config already? Or is it all
just env vars? If just env vars, I'll continue in that vein.

Reply to this email directly or view it on GitHubhttps://github.com//issues/26#issuecomment-35387997
.

Alex MacCaw

+1.415.624.7665
@maccaw

http://alexmaccaw.com

@aendra-rininsland
Copy link
Author

@maccaw Cool, sounds good!

I've done a bunch of git stuff so that aendrew/newsdevlist#master is a straight copy of maccman/monocle's master branch and aendrew/newsdevlist#readding_invites has my changes re-adding user activation against commit 56f4639.

Once I add the system configurable via env vars I'll do a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants