Zeroize intermediate strings allocated during seed construction (#41)

maciejhirsz · May 21, 2023 · adb249a · adb249a
1 parent 4bde6ea
commit adb249a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/seed.rs b/src/seed.rs
@@ -1,6 +1,6 @@
 use std::fmt;
 use unicode_normalization::UnicodeNormalization;
-use zeroize::Zeroize;
+use zeroize::{Zeroize, Zeroizing};
 use crate::crypto::pbkdf2;
 use crate::mnemonic::Mnemonic;
 
@@ -31,8 +31,8 @@ impl Seed {
     ///
     /// [Mnemonic]: ./mnemonic/struct.Mnemonic.html
     pub fn new(mnemonic: &Mnemonic, password: &str) -> Self {
-        let salt = format!("mnemonic{}", password);
-        let normalized_salt = salt.nfkd().to_string();
+        let salt = Zeroizing::new(format!("mnemonic{}", password));
+        let normalized_salt = Zeroizing::new(salt.nfkd().to_string());
         let bytes = pbkdf2(mnemonic.phrase().as_bytes(), &normalized_salt);
 
         Self { bytes }