Fix a bug within LocalAttachmentHandler and regex search returning None causing AttributeError & add html meta tags to transcript #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
doluk
changed the title
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
mahtoid
added a commit
that referenced
this pull request
Jul 1, 2024
* Fix type hinting compatibility with Python < 3.9 (#105) * Merging master in to 2.8.0 (#110) * Versioning * Fix discord import for wrapper namespaces != discord (#104) * Versioning --------- Co-authored-by: mahtoid <git@mahto.id> Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Fix CSS/JS Issues + QOL Improvements (#108) * Versioning * Fix discord import for wrapper namespaces != discord (#104) * Versioning * Fix quick_export() Missing Argument * Remove Use of 'proxy_url' due to Discord's CDN Changes * Fix Embed Colour & Reduce Unnecessary Gaps * Fix Emoji Mis-Alignment * Fix Button Label Padding * Equalise Footer Width * Fix User Pop-Out * Add Hover on User Avatars * Fix Scrolling to Messages * Open Buttons & Images in New Tabs + Fix Audio Container * Change BOT Tag to New APP Tag * Update README * Add .vscode to Git-Ignore * Update README.md for my Fork * Update README.md * Revert README Installation Changes * Revert Asset URL Change back to Proxy URL * Fixed Message Aside Timestamp * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/html/component/component_button.html Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/html/base.html Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/message.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Refactoring * Fixed Military Times --------- Co-authored-by: mahtoid <git@mahto.id> Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update discord link * Fix a bug within LocalAttachmentHandler and regex search returning None causing AttributeError & add html meta tags to transcript (#111) * Ensure unique filenames Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Add html meta tags Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Fix Local File handler Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Fix regex search returning no match causing AttributeError Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Exchange uuid4 with EPOCH timestamp with ms Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> --------- Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Interaction Message (metadata) * Backport Interaction * interaction name --------- Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> Co-authored-by: Argon <laiyeqi@gmail.com> Co-authored-by: mahtoid <git@mahto.id> Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> Co-authored-by: syntax <me@syntax.fo>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In very raw cases the local attachment handler didn't produce unique (enough) filenames for attachements causing later attachments to overwrite previously stored. By replacing the epoch timestamp with an UUID v4, this is prevented and deals even with multiple transcripts at the same time being generated.
This PR also fixes #109 where re.search finds no match and is returning None. This lead to AttributeErrors.
Lastly this PR adds html meta tags to the base.html to enable link preview in various cases.