Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecommerce orders deadlock issue 1175 #1178

Merged
merged 10 commits into from
May 26, 2020

Conversation

giorello
Copy link
Contributor

@giorello giorello commented May 22, 2020

Ref. #1175

DB deadlock is being thrown when orders are getting placed; This could be caused because unnecessary db requests and posts.
In this PR we added:

  • Exception Handle to avoid Order Rollback in case od a deadlock.
  • Filter to avoid set as modified a product when it is already set as modified.
  • Set as modified an order only if it is already created (It would be created with the eCommerce cronjob if it's not).

This changes would avoid the DB deadlocks.

@giorello giorello added this to the 1.1.21 milestone May 22, 2020
@giorello giorello self-assigned this May 22, 2020
Copy link
Contributor

@Santiagoebizmarts Santiagoebizmarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test should be modified if exists or created.

@Santiagoebizmarts Santiagoebizmarts self-requested a review May 26, 2020 16:34
@giorello giorello merged commit 410b2dc into develop May 26, 2020
@giorello giorello deleted the ecommerceOrdersDeadlockIssue-1175 branch May 26, 2020 16:36
@nahall
Copy link

nahall commented Aug 3, 2020

Any update on if this is verified to work properly or if 1.1.21 will be released with it soon? We started having these deadlocks upon upgrading to 1.1.20 and I'm going to need to disable the extension soon if I can't make these deadlocks go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants