Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from 3b1b:master #3

Open
wants to merge 2,132 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2132 commits
Select commit Hold shift + click to select a range
f3571cf
Add random import
3b1b Feb 8, 2024
8417369
Performance improvement for DecimalNumber.set_value
3b1b Feb 8, 2024
2966f35
Pull type definitions used for Generic[SubmobjectType] outside of if …
3b1b Feb 8, 2024
45f8ca7
Specify output type for DecimalMatrix.element_to_mobject
3b1b Feb 8, 2024
c531e56
Fix DecimalNumber.set_value font size issue
3b1b Feb 8, 2024
5784275
Add defaults for Matrix object to have ellipses
3b1b Feb 9, 2024
d44e248
Specify type of argument in Mobject.add
3b1b Feb 9, 2024
4ce8a3b
Fix computation of normals for Surface
3b1b Feb 13, 2024
ed3ac74
Add option to change Euler axes
3b1b Feb 13, 2024
7b577e9
Have matrix keep track of elements and ellipses as lists instead of V…
3b1b Feb 13, 2024
5632fee
Ensure get_opacity returns float
3b1b Feb 21, 2024
712fa30
Ensure Brace.get_tex uses buff key word arg
3b1b Feb 21, 2024
4a89376
Add method for resetting which plane in 3d space behaves like the flo…
3b1b Feb 21, 2024
e784c42
Add big_tick_spacing option NumberLine
3b1b Feb 22, 2024
7edc4b6
Replace numbers_with_elongated_ticks -> big_tick_numbers
3b1b Feb 22, 2024
ffbe5c8
Add type hints for affects_mobject_list
3b1b Mar 2, 2024
9432a73
Let checkpoint_paste work on methods of the current scene
3b1b Mar 2, 2024
2e9c895
Restrict alpha in CountInFrom
3b1b Mar 7, 2024
a5f2ac6
Spacing
3b1b Mar 7, 2024
4d67361
Add shuffled
3b1b Mar 7, 2024
1372cf1
Allow VGroup and Group to accept generators and iterables as arguments
3b1b Mar 7, 2024
2380ffd
Allow LaggedStart to accept an iterable as an argument
3b1b Mar 7, 2024
a6b46c6
Add Mobject.always and Mobject.f_always
3b1b Mar 7, 2024
3c778ba
Add comment to Mobject.animate
3b1b Mar 7, 2024
e124aec
Clarify Mobject.needs_new_bounding_box is private
3b1b Mar 7, 2024
4b14c11
Only reconstruct family as needed
3b1b Mar 7, 2024
fd35433
Change name note_updated_family -> note_changed_family
3b1b Mar 7, 2024
70b839e
Change to only compute has_updater status as needed
3b1b Mar 7, 2024
83cd5d6
Clean up updater matters, prune unused functions
3b1b Mar 7, 2024
d3ba101
Change from tracking time_based_updater and non_time_updater lists se…
3b1b Mar 7, 2024
226d649
Change UpdatersExample scene to feature .always and .f_always syntax
3b1b Mar 7, 2024
27f397e
Have stroke width change continuously with fixed_in_frame status
3b1b Mar 7, 2024
4729e44
Merge pull request #2106 from 3b1b/video-work
3b1b Mar 7, 2024
8235607
remove include_background_rectangle
Mar 11, 2024
fa99eaf
Account for rgba case in point_to_rgb
3b1b Mar 16, 2024
7db69e3
Update input type to LaggedStartMap
3b1b Mar 16, 2024
b26feb7
Adjust Underline configuration
3b1b Mar 21, 2024
6b38347
Undo redundant previous tweak to LaggedStartMap input type
3b1b Mar 21, 2024
7e6a37d
Typo fix: make_number_changable -> make_number_changeable
3b1b Mar 21, 2024
223d671
Remove redundancy
3b1b Mar 21, 2024
ec42326
Fix remover=True case for FadeTransform
3b1b Mar 21, 2024
0509e82
Have border_width default to 0 for lower opacity
3b1b Mar 21, 2024
1d6aa47
Reimplement SpeechBubble and ThoughtBubble
3b1b Mar 21, 2024
7565e93
Better bubble flipping
3b1b Mar 25, 2024
920f240
Revert default underline stroke width
3b1b Mar 25, 2024
f5d1a9c
Keep track of original float matrix in DecimalMatrix
3b1b Mar 25, 2024
772a328
Have FadeTransform target match all uniforms of source
3b1b Apr 13, 2024
c970f77
Removed old argument from example
pdancstep May 3, 2024
3c374c3
Merge pull request #2108 from kubanemil/integer_matrix
3b1b May 3, 2024
88c7e9d
Merge pull request #2132 from pdancstep/example-correction
3b1b May 3, 2024
ab28804
fix: `there_and_back_with_pause`
jkjkil4 May 22, 2024
63e98ee
Update tex_templates.yml
MarkHoo Jun 4, 2024
4feb831
Pass group parameter in LaggedStartMap -> AnimationGroup
3b1b Jun 24, 2024
a07ccf4
Include *args, **kwargs in embed shell event pre_cell and post_cell f…
3b1b Jun 24, 2024
0eae429
fix(animation): `time_span` doesn't work for mobjects with submobjects
osMrPigHead Jul 23, 2024
79c89ad
Remove (outdated) background rectangle arg from example scene
3b1b Jul 31, 2024
d1314e5
Catch screeninfo.ScreenInfoError error
3b1b Jul 31, 2024
57d4732
Remove unused lines
3b1b Jul 31, 2024
a7765dc
Change copy frame position command
3b1b Jul 31, 2024
c1efd14
Add touch and notouch to embed vocabulary
3b1b Jul 31, 2024
a105216
Small clean up
3b1b Jul 31, 2024
bbc89d1
Don't save state after each embed cell call
3b1b Jul 31, 2024
5aeb457
Hot fix for Traicing Tail
3b1b Jul 31, 2024
3ea8393
First pass at a polyline implementation for stroke
3b1b Jul 31, 2024
c6a6503
Cleaning up first pass implementation
3b1b Jul 31, 2024
a3469c2
Simpler compute_subdivisions
3b1b Aug 1, 2024
361817b
Pass fewer values to frag shader
3b1b Aug 1, 2024
aea747b
Final refinements on polyline stroke implementations
3b1b Aug 1, 2024
5decf81
Change default anti_alias_width to 1.5
3b1b Aug 1, 2024
8f78e2e
Merge pull request #2152 from 3b1b/video-work
3b1b Aug 1, 2024
78ddfe2
Merge pull request #2153 from 3b1b/simpler-stroke
3b1b Aug 1, 2024
d644e3b
Merge branch 'master' of github.com:3b1b/manim
3b1b Aug 1, 2024
71814a1
Fix dot updater in graph example
3b1b Aug 1, 2024
b3bbc31
Small clean up to stroke shaders
3b1b Aug 3, 2024
26249c3
Have non-flat stroke operate based on projecting tangents
3b1b Aug 5, 2024
c61c184
Don't bevel corners on inner joints of quadratic bezier curves
3b1b Aug 5, 2024
f363eaa
Add stand in for a ribboning effect
3b1b Aug 5, 2024
557819a
Remove pre-computation of curve points and joint products
3b1b Aug 5, 2024
a592619
Clean up stroke shader
3b1b Aug 5, 2024
2b6ec2d
Add spacing on assert lines
3b1b Aug 5, 2024
b45c71d
Account for Gimbal lock in panning
3b1b Aug 5, 2024
4223bb6
Small cleanup on TracedPath
3b1b Aug 6, 2024
4ff61ed
Default approximate smoothing (non-approx has a bug in 3d)
3b1b Aug 6, 2024
44ec993
Small format fix
3b1b Aug 6, 2024
ec88673
Fix kink issue in flat stroke
3b1b Aug 6, 2024
edb438e
Further clean up to stroke shader
3b1b Aug 6, 2024
61a2b4d
Improve flat stroke for sharp corners with a smooth transition to mit…
3b1b Aug 7, 2024
0dcf630
Change default to non-flat stroke rendering
3b1b Aug 7, 2024
e130625
Handle edge case of single point passed into approx_smooth_quadratic_…
3b1b Aug 7, 2024
0a43a3f
Remove unnecessary stroke vert input
3b1b Aug 7, 2024
bc91e91
In get_euler_angles, add edge case for gimbal lock on the low side
3b1b Aug 7, 2024
f677a02
Allow for manually setting miter or bevel joints
3b1b Aug 7, 2024
70862a0
Don't buff out stroke width by antialias width
3b1b Aug 7, 2024
099aaae
Increase polyline factor
3b1b Aug 7, 2024
bf43a64
Allow for setting flat stroke in VMobject.set_stroke
3b1b Aug 7, 2024
1ff758d
Remove (no longer necessary) specifications of non-flat stroke for 3d…
3b1b Aug 7, 2024
aad2bde
Merge pull request #2155 from 3b1b/video-work
3b1b Aug 7, 2024
c345d76
Patch for glitches associated with non-flat stroke when tangency dire…
3b1b Aug 8, 2024
9f54b85
Change miter threshold to global constant
3b1b Aug 8, 2024
cff3bdf
Remove unnecessary flat stroke option
3b1b Aug 8, 2024
31b6aff
Push up pointwise styling update
3b1b Aug 8, 2024
a485891
Small reformatting
3b1b Aug 8, 2024
af8e523
Merge pull request #2157 from 3b1b/video-work
3b1b Aug 13, 2024
644084d
Merge branch '3b1b:master' into fix-animation-time_span
osMrPigHead Aug 15, 2024
c7acbe5
Brighten up fill
3b1b Aug 15, 2024
a5ba721
Cease useless rendering
3b1b Aug 15, 2024
65d5947
Change ignore_skipping name to force_draw
3b1b Aug 15, 2024
0fa74a7
Merge pull request #2159 from 3b1b/video-work
3b1b Aug 15, 2024
59235d3
Include flat stroke in get_style, set_style, match_style
3b1b Aug 15, 2024
df0ae6f
Fix missing ignore_skipping -> force_draw
3b1b Aug 15, 2024
04347e7
Fix thin stroke issue for low resolutions
3b1b Aug 15, 2024
e2b0c2b
Merge pull request #2160 from 3b1b/video-work
3b1b Aug 15, 2024
4a6e6ca
Double the size of the fill canvas, to effectively do msaa
3b1b Aug 16, 2024
430a88c
Change default border width to 0, and only draw it for opacity 1
3b1b Aug 16, 2024
174f318
Push _data_default initialization into init_data
3b1b Aug 16, 2024
3f15715
Use _data_defaults for initializing fill border width
3b1b Aug 16, 2024
902a4f2
Add white space after assert statements
3b1b Aug 16, 2024
21c0bcb
Don't wait for animations while skipping
3b1b Aug 16, 2024
108db87
Rather than ignoring border with for non-one opacity, go back to havi…
3b1b Aug 16, 2024
d8edccd
Fix zero stroke width issue
3b1b Aug 16, 2024
0267740
Change STROKE_WIDTH_CONVERSION width back to older value
3b1b Aug 16, 2024
c20ce8d
Have arrows default to flat stroke
3b1b Aug 16, 2024
bb42b66
Include fill border width in style
3b1b Aug 16, 2024
ccc84f4
Give Numbers a default border width
3b1b Aug 16, 2024
12d39ef
Merge pull request #2161 from 3b1b/video-work
3b1b Aug 16, 2024
0efa96e
Just use L-inf norm for point equality
3b1b Aug 16, 2024
f9b9cf6
Update so that vbo is not recreated on each from, but is read into
3b1b Aug 17, 2024
24b160f
Update VMobject shader wrapper
3b1b Aug 19, 2024
f2bca00
Add border width and backstroke
3b1b Aug 19, 2024
4174f31
Reorganize, and ensure get_shader_wrapper_list works for general Groups
3b1b Aug 19, 2024
a12fa0c
Remove attributes from VMobject which are now handled in VShaderWrapper
3b1b Aug 19, 2024
4cb16df
Don't apply depth test during winding fill
3b1b Aug 19, 2024
3b5d63d
Add depth shader to handle winding fill depth test.
3b1b Aug 19, 2024
28eba26
Remove stray new line
3b1b Aug 19, 2024
39bcead
Clean up
3b1b Aug 19, 2024
09d147c
Set default border width to 0.5, and keep it for opacities < 1
3b1b Aug 19, 2024
195264f
Stop pretending to support non-winding fill in the fill shader.
3b1b Aug 19, 2024
b7337f0
Remove some ShaderWrapper methods which are no longer needed
3b1b Aug 19, 2024
c064b11
Interleave base_point and unit_normal in the same array
3b1b Aug 19, 2024
058914f
Mildly more efficient CameraFrame.get_view_matrix()
3b1b Aug 19, 2024
b288d53
Get rid of cached _has_stroke and _has_fill parameters
3b1b Aug 19, 2024
7217c9f
Reorganize VShaderWrapper.render_fill
3b1b Aug 20, 2024
6223623
Ensure border width blends better within filled VMobject for opacity < 1
3b1b Aug 20, 2024
0b2c59a
More explicitly unpack v_base_normal
3b1b Aug 20, 2024
08e33fa
Ensure scene properly updates on an embed
3b1b Aug 20, 2024
f12b143
Unify get_shader_wrapper_list, and and better subdivide render groups…
3b1b Aug 20, 2024
5ff80ff
Fix matplotlib color map import
3b1b Aug 20, 2024
e796a0c
Remove stray TODO
3b1b Aug 20, 2024
a8ef962
More direct lerp in Mobject.interpolate
3b1b Aug 20, 2024
e61957a
Fix wrong check for path_func in last commit
3b1b Aug 20, 2024
87ca6e5
Don't treat font size as a uniform
3b1b Aug 20, 2024
b9645ad
Only update shader wrapper when stroke_behind genuinely changes
3b1b Aug 20, 2024
0ac9ee1
Don't deepcopy ShaderWrapper
3b1b Aug 20, 2024
e0191d8
Instead of tracking _shaders_initialized, just check if self.shader_w…
3b1b Aug 20, 2024
0414f87
Use Mobject.set_uniform to reassign flat_stroke
3b1b Aug 20, 2024
b8931e7
When shader_id is updated, have ancestors mark data as changed
3b1b Aug 20, 2024
7474ae1
Change default to flat stroke, except in 3d situations
3b1b Aug 20, 2024
910f28f
Don't have a default flat stroke in set_style
3b1b Aug 20, 2024
0a585b1
Use stash_mobject_pointers on Mobject.deepcopy
3b1b Aug 20, 2024
5eb5a11
Don't have absolute stroke width change with frame size (at least tem…
3b1b Aug 20, 2024
0a313eb
Reorganize quadratic bezier shader files
3b1b Aug 20, 2024
a878469
Reference new shader file structure
3b1b Aug 20, 2024
82582d0
Fewer parameters for stroke frag shader
3b1b Aug 20, 2024
304856e
Remove indices_list argument on ShaderWrapper.read_in
3b1b Aug 20, 2024
7ddbd13
Ensure mobject uniforms get passed to ShaderWrapper on init
3b1b Aug 20, 2024
35ce4c6
Use Mobject.set_uniform in Mobject.set_shading
3b1b Aug 20, 2024
d0cb5b4
Fix normal orientation on Surface
3b1b Aug 20, 2024
dfc5f15
Have border width pre-multiply by alpha, and don't use a separate tex…
3b1b Aug 21, 2024
7487803
Have stroke_behind default to True for VMobjects with fill and no stroke
3b1b Aug 21, 2024
79ec791
Move get_fill_canvas into VShaderWrapper
3b1b Aug 21, 2024
67bedc6
Fix fill_depth_vert_format
3b1b Aug 21, 2024
9a5386b
Instead of passing in joint_products to stroke shader, just track joi…
3b1b Aug 21, 2024
941513d
Only recompute VMobject.get_unit_normal as needed
3b1b Aug 21, 2024
43f1704
Fix computation of joint_angles to handle zero division case
3b1b Aug 21, 2024
0cb7a8f
Only recompute subpath_end_indices as needed
3b1b Aug 21, 2024
0a89725
Tweaking what triggers refreshes
3b1b Aug 21, 2024
c83d03a
Simplify get_subpath_end_indices_from_points
3b1b Aug 21, 2024
b3386ad
Add an option for VMobject.add_line to add a null line
3b1b Aug 21, 2024
eea8416
Default to allowing null lines, except for SVGPaths
3b1b Aug 21, 2024
22ee13a
Have FillArrow take the place of StrokeArrow as the main Arrow
3b1b Aug 21, 2024
ceac4fb
Fix up FillArrow
3b1b Aug 21, 2024
442206f
Go back to non-flat-stroke as the default
3b1b Aug 21, 2024
d870bb2
Fix the non-flat stroke edge case for tangents near line of sight
3b1b Aug 21, 2024
bda8949
Keeps stroke width as a function of pixels, independent of zoom level
3b1b Aug 21, 2024
cfe70ca
Don't let Write override stroke_behind default
3b1b Aug 21, 2024
11df256
Fix error rect
3b1b Aug 21, 2024
d5575cf
Change how joint_angles are computed
3b1b Aug 21, 2024
eda7f81
Update VMobject.is_smooth
3b1b Aug 21, 2024
09bed1f
Allow more file_writer configuration in default_config.yml
3b1b Aug 22, 2024
c8d5e91
Rename shader_dtype -> data_dtype
3b1b Aug 22, 2024
9a7bfdd
For Surface, calculate normals with neighboring points
3b1b Aug 22, 2024
bd2947b
Use preferred group type for FadeTransform
3b1b Aug 22, 2024
ada66ee
Remove stray comment
3b1b Aug 22, 2024
e4007f6
Add glow dot to show light in SurfaceExample
3b1b Aug 22, 2024
bcafcbf
Don't have VMobject refresh joint angles on shift, scale and rotate
3b1b Aug 23, 2024
a08523d
Fix get_subpath_end_indices_from_points
3b1b Aug 23, 2024
5d6a1f3
Count joints near 180 degrees as straight
3b1b Aug 23, 2024
c26ebfc
Have is_closed use the last path
3b1b Aug 23, 2024
e939e1d
Tweak the correction for angle_diffs in get_joint_angles
3b1b Aug 23, 2024
487c714
Remove stray new line
3b1b Aug 23, 2024
4998031
Remove methods and tracking associated with triangulation and non-win…
3b1b Aug 23, 2024
566fc87
Don't keep an outer_vert_indices attribute
3b1b Aug 23, 2024
fcc5dc0
Treat objects fixed in frame as having flat stroke
3b1b Aug 23, 2024
513de19
Clarify that ShaderWrapper id is an int
3b1b Aug 23, 2024
a823901
Only form render groups from Mobjects of the same type
3b1b Aug 23, 2024
8785eb1
Don't have quiet default changes to stroke_behind
3b1b Aug 23, 2024
51de1fb
For some reason RenderGroups must be groups for camera reorientation …
3b1b Aug 23, 2024
441ac77
Change Euler axis limits for xz flat plane
3b1b Aug 26, 2024
827f4db
Clarify where normal is being inverted
3b1b Aug 26, 2024
cd5c436
Tighter (albeit arbitrary) constraint on path end detection
3b1b Aug 26, 2024
36ea70d
Remove whitespace
3b1b Aug 26, 2024
f862455
Merge pull request #2147 from osMrPigHead/fix-animation-time_span
3b1b Aug 26, 2024
7519ce1
Merge branch 'master' of github.com:3b1b/manim into unify-vbo
3b1b Aug 26, 2024
5cf5e49
Don't have joint_angles, unit_normal and path_end_indices get refresh…
3b1b Aug 26, 2024
55a7986
Always stop skipping after checkpoint_paste
3b1b Aug 26, 2024
22a6b47
Always recompute unit normals on rotate
3b1b Aug 26, 2024
e85a1ce
Add Arrow.set_perpendicular_to_camera
3b1b Aug 28, 2024
1e996dc
Fix Arrow.set_perpendicular_to_camera
3b1b Aug 28, 2024
04d77f2
Fix joint angle for lines
3b1b Aug 28, 2024
054261d
Add zero point edge case for point_from_proportion
3b1b Aug 29, 2024
f378d33
Use doubled fill canvas so antialiasing doesn't depend on border width
3b1b Aug 30, 2024
2836acc
Have Write default stroke color match that of the mobject
3b1b Sep 6, 2024
a713868
Add Mobject.get_opacities
3b1b Sep 6, 2024
76fdd02
Go back to default fill border width of 0, except for String
3b1b Sep 6, 2024
e7c540f
Move texture id tracking to ShaderWrapper
3b1b Sep 6, 2024
8f12999
Swap window buffer after blit from another fbo
3b1b Sep 6, 2024
21f9df8
Merge pull request #2163 from 3b1b/unify-vbo
3b1b Sep 6, 2024
a5137a0
Merge pull request #2134 from jkjkil4/fix-there_and_back_with_pause
3b1b Sep 6, 2024
30e6c35
Merge pull request #2138 from MarkHoo/master
3b1b Sep 6, 2024
6b88947
Merge pull request #2079 from TangentSquared/master
3b1b Sep 6, 2024
9011c86
Merge pull request #2061 from floatwoozy/dev
3b1b Sep 6, 2024
9812503
Merge pull request #2059 from germanzhu/fix_vshowpassingflash
3b1b Sep 6, 2024
133cec9
zorder -> z_index
3b1b Sep 6, 2024
c8326d1
zorder -> z_index
3b1b Sep 6, 2024
08f7cb8
zorder -> z_index
3b1b Sep 6, 2024
aebf222
Merge pull request #2057 from germanzhu/add-zorder-mobject
3b1b Sep 6, 2024
1f55832
Clean up around z_index
3b1b Sep 6, 2024
2178ec2
Merge branch 'master' into fix-aspect-ratio
3b1b Sep 6, 2024
05a89d7
Merge pull request #2056 from germanzhu/fix-aspect-ratio
3b1b Sep 6, 2024
6d23df0
Clean up changes associated with fixing aspect ratio issue
3b1b Sep 6, 2024
b6e5b0f
Merge pull request #2036 from LinZezh1/fix_animation
3b1b Sep 6, 2024
df9acfb
Merge pull request #2009 from Varniex/patch-1
3b1b Sep 6, 2024
bcf610d
Merge branch 'master' into patch-8
3b1b Sep 6, 2024
9eda000
Merge pull request #1816 from TurkeyBilly/patch-8
3b1b Sep 6, 2024
f0bf50e
Remove use of gl_VertexID
3b1b Sep 28, 2024
512fb89
Save VMobject. outer_vert_indices
3b1b Oct 1, 2024
95bb67c
Change return type for Mobject.get_shader_data
3b1b Oct 1, 2024
f737823
Add VMobject. get_shader_vert_indices
3b1b Oct 1, 2024
641c03a
Change condition for updating VMobject. outer_vert_indices
3b1b Oct 1, 2024
f69b189
Merge pull request #2171 from 3b1b/fix-vert-index-issue
3b1b Oct 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make sure animations will trigger a refresh for joint products
  • Loading branch information
3b1b committed Jan 31, 2023
commit 60aae748a7dd9183153ccc649b1f1a522cf780f9
6 changes: 1 addition & 5 deletions manimlib/animation/creation.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,7 @@ def __init__(
self.mobject = vmobject

def begin(self) -> None:
# Trigger triangulation calculation
for submob in self.mobject.get_family():
if not submob._use_winding_fill:
submob.get_triangulation()

self.mobject.set_animating_status(True)
self.outline = self.get_outline()
super().begin()
self.mobject.match_style(self.outline)
Expand Down
9 changes: 9 additions & 0 deletions manimlib/mobject/types/vectorized_mobject.py
Original file line number Diff line number Diff line change
Expand Up @@ -1239,6 +1239,15 @@ def apply_points_function(self, *args, **kwargs):
super().apply_points_function(*args, **kwargs)
self.refresh_joint_products()

def set_animating_status(self, is_animating: bool, recurse: bool = True):
super().set_animating_status(is_animating, recurse)
if is_animating:
for submob in self.get_family(recurse):
submob.get_joint_products(refresh=True)
if not submob._use_winding_fill:
submob.get_triangulation()
return self

# For shaders
def init_shader_data(self, ctx: Context):
dtype = self.shader_dtype
Expand Down