Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #124 - fix mysql 5.7 support #148

Merged
merged 1 commit into from
Apr 25, 2024
Merged

issue #124 - fix mysql 5.7 support #148

merged 1 commit into from
Apr 25, 2024

Conversation

pounard
Copy link
Member

@pounard pounard commented Apr 24, 2024 •
edited
Loading

Fixes #124

This is unfinished yet:

  • fix schema alterations
  • fix generated anonymizator update query (window queries are not supported)
  • fix float anonymizator query
  • fix lorem ipsum not working
  • fix string anonymizator not working

@pounard pounard marked this pull request as draft April 24, 2024 14:34
@pounard pounard marked this pull request as ready for review April 24, 2024 15:54
SimonMellerin
SimonMellerin requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@SimonMellerin SimonMellerin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you update .github/workflows/continuous-integration.yml#L215 as well to add MySQL 5.7 ?

And also update the documentation :)

@pounard
Copy link
Member Author

pounard commented Apr 25, 2024

All done, please approve!

@SimonMellerin SimonMellerin merged commit ce5b692 into main Apr 25, 2024
31 checks passed
@SimonMellerin SimonMellerin deleted the issue-124-mysql57-support branch April 25, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonMellerin SimonMellerin SimonMellerin approved these changes

@Lonnytunes Lonnytunes Awaiting requested review from Lonnytunes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support MySQL5.7
2 participants
@pounard @SimonMellerin