Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Unpin libcurl<8.10 #3548

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Oct 17, 2024

To see if libcurl 8.10.1 solved the problem observed with libcurl 8.10.0.

@jjerphan jjerphan added the release::ci_docs For PRs related to CI or documentation label Oct 17, 2024
@jjerphan jjerphan changed the title maint: Unpin libsolv<8.10 maint: Unpin libcurl<8.10 Oct 17, 2024
@jjerphan jjerphan force-pushed the maint/unpin-libcurl branch 2 times, most recently from 6286954 to 698c291 Compare October 17, 2024 13:11
To see if 8.10.1 solved the problem.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
Copy link
Member Author

jjerphan commented Oct 17, 2024

So 8.10.0 likely had a bug which was fixed in 8.10.1.

Do we need to do something to prevent 8.10.0 from being used? E.g. specify libcurl != 8.10.0 for libmamba's runtime dependency?

@JohanMabille
Copy link
Member

I don't think so, unless someone explicitely pings this broken version, the user will get the latest 8.10 version, or something < 8 if he has an upper bound. I would prefer to mark the build 8.10 as broken on ocnda-forge, even if that might be a bit extreme.

@JohanMabille JohanMabille merged commit 0ad7255 into mamba-org:main Oct 17, 2024
32 checks passed
@jjerphan jjerphan deleted the maint/unpin-libcurl branch October 17, 2024 15:01
jjerphan added a commit to jjerphan/micromamba-feedstock that referenced this pull request Oct 17, 2024
See: mamba-org/mamba#3548

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan added a commit to jjerphan/mamba-feedstock that referenced this pull request Oct 17, 2024
See: mamba-org/mamba#3548

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::ci_docs For PRs related to CI or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants