Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement 1404: query builder with sparse data #1595

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

alexowens90
Copy link
Collaborator

Reference Issues/PRs

Closes #1404

Fix copy_frame_data_to_buffer to work with sparse data. Along the way, found and fixed various issues:

  • Off by one error calculating the segment row count when decoding sparse columns
  • Fixed filters and projections on sparse data when two columns have no intersection of their bitsets
  • Fixed underflow bug in Column::set_row_data when there are no physical rows, and similar in backfill_sparse_map
  • Fixed SegmentInMemoryImpl::partition to work with sparse data
  • Fixed grouping on sparse columns
  • Fixed min and max on sparse columns to return NaN if a group had no set bits in the aggregation column

@alexowens90 alexowens90 merged commit bf1d788 into master Jun 4, 2024
114 checks passed
@alexowens90 alexowens90 deleted the enhancement/1404/query-builder-with-sparse-data branch June 4, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix returning sparse column to Python layer after processing pipeline
2 participants