Bugfix 1641: Remove unused staged arg from write_pickle_batch #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poodlewars
reviewed
Jun 24, 2024
| [p.symbol for p in payloads], | ||
| [p.data for p in payloads], | ||
| [p.metadata for p in payloads], | ||
| prune_previous_version=prune_previous_versions, | ||
| pickle_on_failure=True, | ||
| parallel=staged, | ||
| validate_index=False, | ||
| throw_on_error=False, |
alexowens90
force-pushed
the
bugfix/1641/remove-unused-staged-arg-fromwrite-pickle-batch
branch
2 times, most recently
from
c9780db
to
3bb6934
Compare
5 tasks
willdealtry
approved these changes
Jul 19, 2024
alexowens90
added
bug
alexowens90
force-pushed
the
bugfix/1641/remove-unused-staged-arg-fromwrite-pickle-batch
branch
from
3bb6934
to
7789ac9
Compare
alexowens90
deleted the
bugfix/1641/remove-unused-staged-arg-fromwrite-pickle-batch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes
write_pickle_batchto returnDataErrorobjects instead of throwing exceptions, and updated the return type and docstring accordingly.