Bugfix 1552: Set row_count/rows to None in get_description/get_info and batch versions thereof if symbol is pickled #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd batch versions thereof if symbol is pickled
jamesmunro
approved these changes
Jul 8, 2024
alexowens90
added
bug
willdealtry
approved these changes
Aug 21, 2024
alexowens90
deleted the
bugfix/1552/row-count-metadata-misleading-for-pickled-symbols
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1552
The
row_countfield of theget_descriptionreturn value (and equivalent on V1 API, and the return value ofget_num_rows) was misleadingly set if the symbol was pickled. Now it will beNonein this case.Causes (tiny) API change for V2, so wait to merge until 5.0.0