Allowing webpack devServer config to be extended. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx |
|
where is this changes in master? O_o |
|
Looks like this commit reverted my change - 386c319#diff-bb78a211f717f9ff374be3a684ce86d3 @manfredsteyer can you comment on why this was removed? |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, I've really been enjoying using this project, thanks for your work on it!
This PR makes it so that webpack dev server configuration inside of the extra webpack config is actually used when you run
ng serve. The @angular-devkit/angular-builder package actually overwrites the devServer portion of the webpack config to use their defaults.So to be able to overwrite the defaults, ngx-build-plus needs to implement its own version of
_buildServerConfig, which is what I've done in this PR.