Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Storage.php #5

Merged
merged 1 commit into from
Mar 31, 2014
Merged

Update Storage.php #5

merged 1 commit into from
Mar 31, 2014

Conversation

oliverde8
Copy link
Contributor

On a relay server the map list isn't returned. This fixes the issue with the current map being null while that information can be received

On a relay server the map list isn't returned. This fixes the issue with the current map being null while that information can be received
@magnetik
Copy link
Contributor

So this caused an exception when using ManiaLive on a relay server?

@oliverde8
Copy link
Contributor Author

$this->maps[$this->connection->getNextMapIndex()] is an undefined
offset, which causes an exception.

The reason for this is that the $this->connection->getMapList(-1, 0);
returns only one map.

$this->connection->getNextMapIndex() seems to work fine but as there
isn't the list of the maps ...

I don't know it might be a bug of the dedicated. In TMNF this works
fine because you can get the list of the maps.

Oliver De Cramer
E-mail : *oliverde8@gmail.com
*Web : oliver-decramer.com http://oliver-decramer.com/

On Mon, Mar 31, 2014 at 10:58 AM, Baptiste Lafontaine <
notifications@github.com> wrote:

So this caused an exception when using ManiaLive on a relay server?

Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-39066831
.

magnetik added a commit that referenced this pull request Mar 31, 2014
Fix nextMap when using ManiaLive on relay server
@magnetik magnetik merged commit 2093d82 into maniaplanet:master Mar 31, 2014
@magnetik
Copy link
Contributor

Thanks :)

@oliverde8
Copy link
Contributor Author

no problem.

Oliver De Cramer
E-mail : *oliverde8@gmail.com
*Web : oliver-decramer.com http://oliver-decramer.com/

On Mon, Mar 31, 2014 at 11:03 AM, Baptiste Lafontaine <
notifications@github.com> wrote:

Thanks :)

Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-39067228
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants