Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Updates cluster example for new cluster APIs #264

Merged
merged 6 commits into from
Jan 22, 2019

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented Jan 13, 2019

This PR is waiting for mapbox/mapbox-gl-native#12952 to land in mapbox-gl-native

Updates cluster example to demostrate new cluster APIs.

Single tap on a cluster to see cluster information.
Double tap on a cluster to zoom into that cluster so that it expands to its children.

Copy link
Contributor

@captainbarbosa captainbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some code comment suggestions for the Swift example that also apply to the Obj-C side as well ✏️ let me know if you have questions.

Examples/Swift/ClusteringExample.swift Outdated Show resolved Hide resolved
Examples/Swift/ClusteringExample.swift Outdated Show resolved Hide resolved
Examples/Swift/ClusteringExample.swift Outdated Show resolved Hide resolved
Examples/Swift/ClusteringExample.swift Outdated Show resolved Hide resolved
Examples/Swift/ClusteringExample.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@captainbarbosa captainbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some minor comment formatting - this is good to go ✅

@julianrex julianrex merged commit 89d02fa into ios-v4.8.0 Jan 22, 2019
@julianrex
Copy link
Contributor Author

Thanks for fixing the words!

@julianrex julianrex deleted the jrex/cluster-update branch January 22, 2019 23:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants