This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Updates cluster example for new cluster APIs #264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
force-pushed
the
ios-v4.8.0
branch
from
January 17, 2019 21:14
b46b95f
to
ecb2801
Compare
julianrex
force-pushed
the
jrex/cluster-update
branch
from
January 18, 2019 19:58
3d4f993
to
3da05b7
Compare
captainbarbosa
suggested changes
Jan 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some code comment suggestions for the Swift example that also apply to the Obj-C side as well ✏️ let me know if you have questions.
captainbarbosa
approved these changes
Jan 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some minor comment formatting - this is good to go ✅
Thanks for fixing the words! |
friedbunny
pushed a commit
that referenced
this pull request
Jan 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is waiting for mapbox/mapbox-gl-native#12952 to land in mapbox-gl-nativeUpdates cluster example to demostrate new cluster APIs.
Single tap on a cluster to see cluster information.
Double tap on a cluster to zoom into that cluster so that it expands to its children.