Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port per-tile glyph/icon atlases #4876

Closed
jfirebaugh opened this issue Jun 23, 2017 · 1 comment · Fixed by #5190
Closed

Port per-tile glyph/icon atlases #4876

jfirebaugh opened this issue Jun 23, 2017 · 1 comment · Fixed by #5190
Assignees
@jfirebaugh
Labels
GL native → GL JS For feature parity with Mapbox Maps SDK on a native platform

Comments

@jfirebaugh
Copy link
Contributor

jfirebaugh commented Jun 23, 2017 •
edited
Loading

Port mapbox/mapbox-gl-native#9213 / mapbox/mapbox-gl-native#9355.
@jfirebaugh jfirebaugh added the GL native → GL JS For feature parity with Mapbox Maps SDK on a native platform label Jun 23, 2017
@jfirebaugh jfirebaugh self-assigned this Jun 26, 2017
@jfirebaugh jfirebaugh mentioned this issue Jun 27, 2017
Merged
@jfirebaugh jfirebaugh mentioned this issue Jul 5, 2017
Closed
@jfirebaugh
Copy link
Contributor Author

The gl-native implementation relies on transferring references to immutable objects across threads. Unfortunately, we don't have that option in JS -- we can only copy JSON or move ArrayBuffers. For icons and glyphs, that means copying image and glyph data from the main thread to the worker. Might be expensive. :(

SharedArrayBuffer is a possible future solution, but it'll be a while before support is widespread.

@jfirebaugh jfirebaugh mentioned this issue Jul 24, 2017
Closed
@jfirebaugh jfirebaugh mentioned this issue Aug 3, 2017
Merged
This was referenced Aug 22, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfirebaugh jfirebaugh

Labels
GL native → GL JS For feature parity with Mapbox Maps SDK on a native platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Per-tile glyph and icon atlases mapbox/mapbox-gl-js
1 participant
@jfirebaugh