Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] make{Glyph,Image}Atlas only once for any number of symbol layers #9355

Merged
merged 1 commit into from
Jul 6, 2017
Merged

[core] make{Glyph,Image}Atlas only once for any number of symbol layers #9355

merged 1 commit into from
Jul 6, 2017

Conversation

jfirebaugh
Copy link
Contributor

Fix an oversight from #9213 / f73f451.

@jfirebaugh jfirebaugh requested a review from kkaefer June 23, 2017 18:39
@kkaefer kkaefer added the Core The cross-platform C++ core, aka mbgl label Jun 23, 2017
kkaefer
kkaefer reviewed Jun 26, 2017
View reviewed changes
Copy link
Contributor

@kkaefer kkaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the oversight?

@jfirebaugh
Copy link
Contributor Author

That it was re-making the atlases once for every symbol layer, even though they will be identical.

@kkaefer
Copy link
Contributor

kkaefer commented Jun 29, 2017

Do you mean SymbolLayout?

@jfirebaugh
Copy link
Contributor Author

Yes, once per SymbolLayout.

@jfirebaugh
Copy link
Contributor Author

@kkaefer 🍏 ?

@jfirebaugh jfirebaugh merged commit 754d2f3 into master Jul 6, 2017
@jfirebaugh jfirebaugh deleted the optimze-symbol-atlases branch July 6, 2017 12:28
@jfirebaugh jfirebaugh mentioned this pull request Jul 6, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kkaefer kkaefer kkaefer approved these changes

Assignees
No one assigned
Labels
Core The cross-platform C++ core, aka mbgl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfirebaugh @kkaefer