Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-browser failures by unpinning chrome version #12509

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

SnailBones
Copy link
Contributor

@SnailBones SnailBones commented Jan 10, 2023

Related to #10887

Runs of test-browser started failing today on the install Chrome step with the following error:

Google Chrome is not currently installed; installing it
Preparing Chrome installation for Debian-based systems
https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_91.0.4472.164-1_amd64.deb:
2023-01-10 23:01:29 ERROR 404: Not Found.
/bin/bash: line 129: google-chrome-stable: command not found
Google Chrome v91.0.4472.164 (stable) failed to install.

The pinned version of Chrome is no longer available, tests pass after we remove it, defaulting to the latest version.

  • briefly describe the changes in this PR

@SnailBones SnailBones added testing 💯 skip changelog Used for PRs that do not need a changelog entry labels Jan 10, 2023
@SnailBones SnailBones requested a review from a team as a code owner January 10, 2023 23:28
.circleci/config.yml Outdated Show resolved Hide resolved
@SnailBones SnailBones merged commit 184421e into main Jan 11, 2023
@SnailBones SnailBones deleted the aidan/browser-test-fix branch January 11, 2023 01:28
stepankuzmin pushed a commit that referenced this pull request Feb 4, 2023
* Remove pinned chrome version from test-browser
stepankuzmin added a commit that referenced this pull request Feb 6, 2023
* Update `tiny-sdf` to v2.0.6

* Update CHANGELOG and package version

* Fix `test-browser` failures by unpinning chrome version (#12509)

---------

Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Used for PRs that do not need a changelog entry testing 💯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants