Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant call to prerender from old code, some review fixes #12539

Merged
merged 2 commits into from
Jan 24, 2023
Merged

remove redundant call to prerender from old code, some review fixes #12539

merged 2 commits into from
Jan 24, 2023

Conversation

akoylasar
Copy link
Contributor

fixes some of the issues raised here #12182 (review)

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog></changelog>

@akoylasar akoylasar added the skip changelog Used for PRs that do not need a changelog entry label Jan 24, 2023
@akoylasar akoylasar requested a review from a team as a code owner January 24, 2023 14:59
mourner
mourner requested changes Jan 24, 2023
View reviewed changes
src/geo/lng_lat.js Outdated Show resolved Hide resolved
@akoylasar akoylasar merged commit 60111db into main Jan 24, 2023
@akoylasar akoylasar deleted the fouad/custom-layer-minor-bugfix branch January 24, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

@astojilj astojilj Awaiting requested review from astojilj

Assignees
No one assigned
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akoylasar @mourner