release-drink backport: Fix Webpack production mode compatibility #6981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
requested review from
anandthakker and
mourner
and removed request for
anandthakker
mourner
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #6956 to release-drink
A proposal for fixing #4359. Sets
ignoreGlobal: trueoption forrollup-plugin-commonjsplugin, turning off its handling of theglobalkeyword in CommonJS modules, and upgrades the plugin to the latest version (because the option didn't work properly in the previous one). In particular, it stops transforming top-levelthisreference into a variable that contains thetypeof globalcheck (which consequently triggered Webpack issues).One consequence of the fix is that GL JS will throw a runtime error when it encounters a reference to the
globalkeyword. However, there are no such instances in the bundle currently — the only real reference I found (in the browserified nodeassertmodule) gets treeshaken away because it's in unused methods. So in theory this fix won't bring much trouble unless we plan on using Node-targeted modules with theglobalkeyword in future.Thanks a lot to @Aendrew who provided a minimal repro that helped me find this fix.