Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Move InfoWindow Classes To annotations Package #2588

Closed
bleege opened this issue Oct 10, 2015 · 5 comments
Closed

Move InfoWindow Classes To annotations Package #2588

bleege opened this issue Oct 10, 2015 · 5 comments
Assignees
@ljbade
Labels
Android Mapbox Maps SDK for Android
Milestone
android-v2.1.0

Comments

@bleege
Copy link
Contributor

bleege commented Oct 10, 2015

As discussed #2478 (comment) it makes for a more robust API and ease of developer use to have the InfoWindow classes in the annotations package instead of the views package.

I had gotten started on this in #2448 before deciding that the ticket didn't need addressing now. I'll update the original commit message on the branch and associate it with this ticket for better tracking.

/cc @ljbade @tobrun
@bleege bleege added the Android Mapbox Maps SDK for Android label Oct 10, 2015
@bleege bleege self-assigned this Oct 10, 2015
@bleege bleege added this to the android-v2.1.0 milestone Oct 10, 2015
@bleege
Copy link
Contributor Author

bleege commented Oct 10, 2015

Hmm... ran into some local issues amending the commit message. At this stage it's just easier to forget about the 2448-infowindowontouchlistener and redo the changes in a new branch.

bleege added a commit that referenced this issue Oct 10, 2015
@bleege
[android] #2588 - Moving InfoWindow classes to annotations package
dc98966
@bleege bleege mentioned this issue Oct 10, 2015
Merged
@bleege
Copy link
Contributor Author

bleege commented Oct 10, 2015

Ok, I just got it redone on 2588-move-infowindow-classes branch and successfully tested locally. Will let Travis CI do it's thing and when it's ready to go will merge to master.

@ljbade
Copy link
Contributor

ljbade commented Oct 11, 2015

@bleege I'm going to make another PR that makes getTopOffsetPixelsForAnnotationSymbol private by passing it to Marker in addMarker. This makes more sense in the OOP idea that this should be a property of the Marker not the MapView.

@ljbade ljbade reopened this Oct 11, 2015
@ljbade ljbade assigned ljbade and unassigned bleege Oct 11, 2015
@ljbade
Copy link
Contributor

ljbade commented Oct 12, 2015

PR made: #2592

ljbade pushed a commit that referenced this issue Oct 13, 2015
[android] #2588 - Make getTopOffsetPixelsForAnnotationSymbol private.
67f0108
@ljbade
Copy link
Contributor

ljbade commented Oct 13, 2015

Merged.

@ljbade ljbade closed this as completed Oct 13, 2015
tobrun added a commit that referenced this issue Oct 13, 2015
@tobrun
Revert "[android] #2588 - Make getTopOffsetPixelsForAnnotationSymbol …
7153f12 
…private."

This reverts commit 67f0108.
@ljbade ljbade mentioned this issue Oct 15, 2015
Merged
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
@bleege
[android] mapbox#2588 - Moving InfoWindow classes to annotations package
048894e
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
[android] mapbox#2588 - Make getTopOffsetPixelsForAnnotationSymbol pr…
dd68bd3 
…ivate.
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
@tobrun
Revert "[android] mapbox#2588 - Make getTopOffsetPixelsForAnnotationS…
9794c07 
…ymbol private."

This reverts commit 67f0108.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ljbade ljbade

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v2.1.0
Development

No branches or pull requests
3 participants
@mourner @bleege @ljbade