Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Integrate hybrid style #935

Closed
1ec5 opened this issue Mar 2, 2015 · 10 comments
Closed

Integrate hybrid style #935

1ec5 opened this issue Mar 2, 2015 · 10 comments
Assignees
Labels
iOS Mapbox Maps SDK for iOS
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 2, 2015

Per discussion with @incanus, this issue tracks adding the “hybrid” style to the example apps. See mapbox/mapbox-gl-styles#35, mapbox/mapbox-gl-js#1041.

@incanus
Copy link
Contributor

incanus commented Mar 2, 2015

Idea here is parity with what devs expect of -[MKMapView.mapType].

@incanus incanus added this to the iOS Beta milestone Mar 2, 2015
@incanus incanus added the iOS Mapbox Maps SDK for iOS label Mar 2, 2015
@1ec5
Copy link
Contributor Author

1ec5 commented Mar 3, 2015

Depends on #939.

@1ec5
Copy link
Contributor Author

1ec5 commented Mar 6, 2015

To your left, contours+labels. To your right, just labels:
contours labels labels

@1ec5
Copy link
Contributor Author

1ec5 commented Mar 6, 2015

Here’s what we’re getting out of the style .json: http://a.tiles.mapbox.com/v4/mapbox.mapbox-terrain-v2/{z}/{x}/{y}.vector.pbf?access_token=…. The vector glyph zoom level is always one lower than the raster tile zoom level.

@1ec5
Copy link
Contributor Author

1ec5 commented Mar 6, 2015

At the initial viewport, map.getState() is 14.5. The TileDatas are being created with z14 for the contours and labels and z15 for the satellite tiles, based on the return value of Source::getZoom().

@incanus
Copy link
Contributor

incanus commented Mar 7, 2015

@jfirebaugh I believe you said you were going to take a look at this? Want to self-assign, or just take a peek?

@gundersen
Copy link

@incanus can we use Mapbox Terrain rather than Mapbox Outdoors in when we launch. Terrain gets us the wins of terrain w/ the wins of Mapbox Streets.

@ajashton what are your thoughts here on the 1 style we should launch in GL w/ the iOS launch?

@jfirebaugh jfirebaugh self-assigned this Mar 7, 2015
@jfirebaugh
Copy link
Contributor

The rendering errors (black labels, missing contours) are reproducible on any platform.

9897ae7 fixes contour rendering. fddd27f fixes label rendering but I'm not sure if it's correct. @kkaefer?

@incanus incanus mentioned this issue Mar 9, 2015
@incanus
Copy link
Contributor

incanus commented Mar 9, 2015

Splitting vector terrain out to #964 to keep this ticket purely raster satellite + vector labels (i.e. "hybrid").

@1ec5 1ec5 closed this as completed in 78900c6 Mar 9, 2015
1ec5 added a commit that referenced this issue Mar 10, 2015
refs #935: remove dispatch_once, favor property use, and return immutable styles
@incanus
Copy link
Contributor

incanus commented Mar 12, 2015

This will come in in b2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

4 participants