This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Disable rotation gesture when pinch zooming #10026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-rework-rotate-gesture-invocation
branch
2 times, most recently
from
1faa20b
to
50434c7
Compare
tobrun
force-pushed
the
tvn-rework-rotate-gesture-invocation
branch
from
50434c7
to
95ee81a
Compare
Guardiola31337
approved these changes
Sep 21, 2017
| scaleGestureDetector.onTouchEvent(event); | ||
| rotateGestureDetector.onTouchEvent(event); |
|
@tobrun I've changed the dependency to 5.1.4@aar now and when im pinching to zoom my map is still spinning around, do i need to do something else to turn this off? |
|
Could you show me an gif or a video of it? |
|
@tobrun I'll Get One Sent Over As Soon As Possible Mate. - Cheers For Getting Back To Me :) |
|
@tobrun Attached Is A GIF, When Zooming In You're Battling With The Rotation Also, I'm Not Sure If This Is Supposed To Happen As Standard?
Many Thanks |
|
This is what I'm seeing with 5.1.4:
The expected UX is as follows: You are allowed to rotate and afterwards scale, you aren't allowed to scale and afterwards rotate. |
|
Let Me Test This Again, I Have Just Tested On Android 4.1.2 Device (As This Is What The App Im Doing Is Being Developed For, It's A PDA) - I Am Now Unable To Pinch To Zoom, I Can Rotate, Single Finger Double Tap To Zoom In And Double Finger Double Tap To Zoom Out All Works Fine, I'm Unable To Pinch To Zoom IN or OUT. Let Me Test On My Android 8.0 Google Pixel (Device of GIF) |
|
Hi @tobrun However, regarding this closed issue #9413, it's definitely better. I can now zoom and drag at the same time ;) |
|
I'm still not able to Pinch to Zoom on Android 4.1.2 Device? Any Idea What's Causing This? |
|
Thank you both for pitching in, re. delay, this is the lowering of the touchslop here. Would you both be able to take 5.2.0-SNAPSHOT for a spin and see how it performs there? To use snapshots, add the snapshots repo in the root build.gradle file: allprojects {
repositories {
jcenter()
maven { url "http://oss.sonatype.org/content/repositories/snapshots/" }
}
}In you app build.gradle replace current dependency with: compile(com.mapbox.mapboxsdk:mapbox-android-sdk:5.2.0-SNAPSHOT@aar) {
transitive = true
} |
|
@tobrun What is it i'm testing with this? Should i be able to pinch to zoom on my 4.1.2 Android Device? |
|
I'm Getting The Following Error And Crash On Google Pixel Android 8.0 When Loading MapView Project build.gradle app build.gradle ERROR |
|
Here Is The Error From Motorola TC55 on Android 4.1.2 ERROR |
|
@tobrun |
|
@Danny-James @paulVulog based on your feedback, looks like you're still seeing some issues with the latest version of the code. Consindering this a closed PR, and for easier tracking, would you mind opening a separate ticket? it'd be very helpful if you could add the Mapbox version you're trying, the device you're using, and any snippets and graphics that could help us reproduce your issues. Thansk! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks our rotation gesture handling to not execute when pinch zooming is occurring.
This UX matches what other map applications are doing atm.