[ios] Long-press attribution button to show SDK version #10650
Conversation
|
|
||
| if (shouldShowVersion) | ||
| { | ||
| attributionController.title = [title stringByAppendingFormat:@" %@", [NSBundle mgl_frameworkInfoDictionary][@"MGLSemanticVersionString"]]; |
| { | ||
| BOOL shouldShowVersion = [sender isKindOfClass:[UILongPressGestureRecognizer class]]; |
There was a problem hiding this comment.
For what it’s worth, it’s pretty unlikely that a developer implementing a custom ℹ️ button will hook up a long press gesture recognizer to this method.
There was a problem hiding this comment.
This is here because I reused the existing showAttribution: method for the long press gesture recognizer target, so this is where we determine what the user did to trigger the attribution sheet.
There was a problem hiding this comment.
Oh, hrm — is your point that we may lose this functionality when developers roll their own? That is true, which means that maybe we should also implement one of your suggestions in #6551 (comment).
There was a problem hiding this comment.
→ b51250464a475fb2294d8e1d8b9171e66aace40a b99b866
friedbunny
force-pushed
the
fb-attribution-sheet-version-6551
branch
2 times, most recently
from
b512504
to
b99b866
Compare
friedbunny
force-pushed
the
fb-attribution-sheet-version-6551
branch
from
a2da237
to
4f31b07
Compare
Fixes #6551. Long-press on the attribution button to show the SDK release version in the title of the attribution action sheet. This provides a convenient, one-step method to determine what version of our SDK an app is running (without resorting to digging through its bundle).
German localization.
/cc @1ec5 @fabian-guerra @akitchen